-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove common_timestamp function from postgis driver #1623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1623 +/- ##
===============================================
+ Coverage 85.23% 85.24% +0.01%
===============================================
Files 144 144
Lines 15633 15685 +52
===============================================
+ Hits 13325 13371 +46
- Misses 2308 2314 +6 ☔ View full report in Codecov by Sentry. |
pjonsson
reviewed
Aug 30, 2024
pjonsson
reviewed
Aug 30, 2024
pjonsson
reviewed
Aug 30, 2024
pjonsson
reviewed
Aug 30, 2024
SpacemanPaul
force-pushed
the
rem-common-ts
branch
from
September 19, 2024 04:22
b91cb58
to
f5b6f53
Compare
SpacemanPaul
force-pushed
the
rem-common-ts
branch
from
September 19, 2024 05:28
f5b6f53
to
8440bd7
Compare
SpacemanPaul
force-pushed
the
rem-common-ts
branch
from
September 19, 2024 05:45
8440bd7
to
5562c50
Compare
Ariana-B
reviewed
Sep 19, 2024
Ariana-B
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
The
common_timestamp
custom postgresql function was previously used in both postgis and postgres index drivers to ensure correct timezone handling when inserting and extracting time data. The use of this function significantly complicated efficient indexing of time fields in both drivers.With SQLAlchemy2, most of the functionality of the
common_timestamp
function can be handled with a simple type cast. Some complexities regarding handling of:a) data with no explicit timezone marker,
b) databases with a default timezone other than UTC, and
c) the "find duplicates with time" method
necessitated some further internal restructure and changes to internal APIs.
Due to these complexities, I have only applied these changes to the postgis driver.
docs/about/whats_new.rst
for all changes