CORS fixed and started to add APP_URL to replace in NGINX automatically the domain. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebanesr
suggested changes
Oct 26, 2023
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Instead of copying this into the Docker container, can we run this sed command to replace 0.0.0.0 during the make install process? Everything else looks good
There was a problem hiding this comment.
Actually the issue is that the docker start and you cannot edit the conf file because is locked. So this is why I did not found a solution yet. If I stop the NGINX will drop me out so cannot edit.
A solution would be to have the nginx.template.conf with a variable and replace it from makefile. and build it after ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS fixed and started to add APP_URL to replace in NGINX automatically the domain.