Skip to content

Commit

Permalink
Fix horrible issue with karma-bro
Browse files Browse the repository at this point in the history
We still (after close to 2 days digging into this) don't understand
what's going wrong here. Despite apparently having restored all package
versions to ones that previously worked, we've been unable to get this
working again.

While debugging the issue we discovered that adding a bundle call in the
prebundle hook gets the tests passing again. This is a horrible fix and
doesn't relieve us of the need to understand what's going on here and
how to fix it, but I don't want to burn any more time on this problem
for now.
  • Loading branch information
nickstenning committed Dec 10, 2014
1 parent 9a4f7b9 commit e505e4a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ module.exports = function (karma) {
// This allows annotator-plugintools to require annotator as
// 'annotator' in the test environment.
bundle.require('./src/annotator', {expose: 'annotator'});
// This, for reasons that remain entirely unclear, fixes an
// issue where the above require doesn't seem to work, and the
// karma build dies saying "Cannot find module 'annotator' ..."
bundle.bundle();
}
},

Expand Down

0 comments on commit e505e4a

Please sign in to comment.