Fix __salt__ when used via __utils__ (bsc#1220357) #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
force-pushed
the
openSUSE/backport/3006.0/65696-fix-__salt__-used-via-__utils__
branch
3 times, most recently
from
0cff225
to
d30d308
Compare
vzhestkov
changed the title
Fix cases where loaded execution modules call a __utils__ method which in-turn calls a execution module via __salt__ method.
vzhestkov
force-pushed
the
openSUSE/backport/3006.0/65696-fix-__salt__-used-via-__utils__
branch
from
d30d308
to
4fd5395
Compare
3 tasks
|
Closing in favor of #683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of saltstack/salt#65696
In some cases
salt-callon the salt-ssh client side is rereading/etc/salt/minionexplicitly what doesn't make any sense.The upstreram PR contains the fix of it in ef140fc
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23799
Previous Behavior
In some cases
salt-callon the salt-ssh client side is rereading/etc/salt/minion.New Behavior
Prevent
salt-callof rereading/etc/salt/minionwith no reason.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.