Make MWorkers reconnecting to EventPublisher if it was killed #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes MWorkers to be able to recoonect with
salt.transport.ipc.IPCMessageClient
to theEventPublisher
after killing it with OOM or any other reason, so it makessalt-master
to be able to self recover after killing theEventPublisher
.Implementation of
timeout
andtries
is a kind of bonus there, the main fix is in the way of handlingStreamClosedError
exceptions.The reason why there is norelated upstream change:
salt.transport.ipc
is specified as deprecated for3009
and in themaster
eithertcp
orzmq
can be used, but they have different implementation of this part which can be not affected, but it's better to check it deeper on switching the version.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23526
Previous Behavior
On killing
EventPublisher
subprocess thesalt-master
is still running but is not able to handle the incoming events the proper way as the stream to theEventPublisher
inMWorker
was closed and not restored, so thesalt-master
is running but not functional.New Behavior
The
salt-master
is able to self recover on killingEventPublisher
and continue handling the events.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.