Skip to content

Commit

Permalink
Use skipif instead of skip_if as it seems not behaving equally
Browse files Browse the repository at this point in the history
  • Loading branch information
meaksh committed Feb 15, 2024
1 parent 425fdd3 commit a591123
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/pytests/functional/modules/test_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
pytestmark = [
pytest.mark.skip_unless_on_linux,
pytest.mark.slow_test,
pytest.mark.skip_if(INSIDE_CONTAINER, reason="No systemd in container."),
pytest.mark.skipif(INSIDE_CONTAINER, reason="No systemd in container."),
]

log = logging.getLogger(__name__)
Expand Down
2 changes: 1 addition & 1 deletion tests/pytests/integration/ssh/test_master.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
INSIDE_CONTAINER = os.getenv("HOSTNAME", "") == "salt-test-container"


@pytest.mark.skip_if(INSIDE_CONTAINER, reason="No systemd in container.")
@pytest.mark.skipif(INSIDE_CONTAINER, reason="No systemd in container.")
@pytest.mark.skip_if_not_root
def test_service(salt_ssh_cli, grains):
service = "cron"
Expand Down
2 changes: 1 addition & 1 deletion tests/pytests/scenarios/setup/test_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
pytest.mark.windows_whitelisted,
pytest.mark.skip_initial_onedir_failure,
pytest.mark.skip_if_binaries_missing(*KNOWN_BINARY_NAMES, check_all=False),
pytest.mark.skip_if(INSIDE_CONTAINER, reason="No gcc and python3-devel in container."),
pytest.mark.skipif(INSIDE_CONTAINER, reason="No gcc and python3-devel in container."),
]


Expand Down

0 comments on commit a591123

Please sign in to comment.