Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #153 Option for Passcode Change Provided #161

Open
wants to merge 1 commit into
base: redesign
Choose a base branch
from

Conversation

garvit984
Copy link
Collaborator

@garvit984 garvit984 commented Mar 21, 2020

Profile photo problem solved

FIX#153 Option for Passcode Change

Fixes #153

Please Add Screenshots If there are any UI changes.
g

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Profile photo problem solved

FIX#153 Option for Passcode Change
@jawidMuhammadi
Copy link

@garvit984 Please make sure to send different PRs for different changes you make. Your PR titled as Option for Passcode Change Provided but it includes code for Profile Photo Problem and other changes like changing classpath 'com.android.tools.build:gradle:3.3.2''s version to 3.6.1

@garvit984
Copy link
Collaborator Author

@jawidMuhammadi I have squashed them into a single commit.

@jawidMuhammadi
Copy link

@garvit984 during squashing, please pick the commits which are related to this PR only.

@garvit984
Copy link
Collaborator Author

Please review it. @luckyman20 @rahulg963

@garvit984
Copy link
Collaborator Author

@abhijitramesh Please review it

@garvit984
Copy link
Collaborator Author

Currently, I need to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants