Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Add Beneficiaries and Show Beneficiaries Screen #119

Open
wants to merge 1 commit into
base: redesign
Choose a base branch
from

Conversation

rchtgpt
Copy link
Member

@rchtgpt rchtgpt commented Jan 21, 2020

Fixes Issue

Fixes #106

GIF

ezgif com-video-to-gif (12)

Description

I have not added the fonts and bottom navigation bar as they would be added in a different PR to prevent merge conflicts. I have added a sample recyclerView as well.
The color of the focused button is not the same as the mockup because this looked better in terms of design and contrast.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@laxyapahuja
Copy link

hey @Rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.

@rchtgpt
Copy link
Member Author

rchtgpt commented Jan 22, 2020

hey @Rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend.

Thanks for your comment! I have added a recyclerView with dummy details :D

@rchtgpt
Copy link
Member Author

rchtgpt commented Jan 23, 2020

updated!

@laxyapahuja
Copy link

The button says "Submit Beneficiaries" but I think it should say "Submit Beneficiary".

@laxyapahuja
Copy link

Also, you can see the bottom corner radius of the CardView which I think affects the UI.

@rchtgpt
Copy link
Member Author

rchtgpt commented Jan 23, 2020

@laxyapahuja, thanks for pointing out! Made the changes.

@laxyapahuja
Copy link

hey @Rachittt, I think you can add the fonts now as #114 is merged.

@garvit984
Copy link
Collaborator

For some of the devices, the grey card just overlaps the heading. There should be a scroll view for adding a new beneficiary.

@garvit984
Copy link
Collaborator

@Rachittt Can you please look into the changes requested above by me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants