feat: redesign login UI #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laxyapahuja hey! Please send your PR on |
rchtgpt
reviewed
Jan 7, 2020
|
Also, I think it would be better if we import the fonts in a different PR because if everyone started adding font files with their PRs then it can lead to merge conflicts. |
|
@laxyapahuja Yes, @Rachittt is correct please do so. |
luckyman20
requested changes
Jan 9, 2020
Already fixed :) |
|
I can still see .ttf files. |
updated :D |
luckyman20
reviewed
Jan 11, 2020
luckyman20
reviewed
Jan 14, 2020
rchtgpt
reviewed
Jan 18, 2020
|
updated :) |
This was referenced Jan 24, 2020
2 tasks
|
@laxyapahuja please look into the changes requested and conflicting files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #100
Screenshots
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.