Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Economy input vars #303

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Conversation

paopis
Copy link
Contributor

@paopis paopis commented Jun 26, 2023

Included new variables in the economy.yaml file to be able to upload the input data that is used in the macroeconomic models to characterize the different scenarios.

Included unemployment in millions and unemployment rate into the economic yaml.
Added new variables for the economic list. The variables are related to input data used in the macroeconomic models under the different scenarios.
Added new variables for the economic list. The variables are related to input data used in the macroeconomic models under the different scenarios.
@@ -212,4 +212,38 @@
unit: [EUR_2020/t CO2, USD_2010/t CO2]
skip-region-aggregation: true


- Extraction Limit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have one limit across all fossil resources? Shouldn't this be distinguished between different fuels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is true. Nevertheless, we have used a single parameter to control the extraction of oil and gas. I can make three parameters: one for oil and one for gas and use the same parameter in the data upload, though. I will make a new pull request with the updated variables

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, do NOT make a new pull request - this is not how GitHub works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I only updated the description of the variables, then.

Split the variable for the extraction of fossil fuels into one variable for extraction of crude oil and one variable for extraction of natural gas.
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions to use the hierarchy-notation.

definitions/variable/economy/economy.yaml Outdated Show resolved Hide resolved

- Extraction Limit for Crude Oil:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Extraction Limit for Crude Oil:
- Extraction Limit|Crude Oil:

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paopis!

@danielhuppmann danielhuppmann merged commit 4448567 into openENTRANCE:main Jun 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants