Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coll/han: Implement MPI_Alltoallv in han using SMSC and XPMEM #12747

Merged
merged 1 commit into from
Aug 19, 2024
Merged

coll/han: Implement MPI_Alltoallv in han using SMSC and XPMEM #12747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ompi/mca/coll/han/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ coll_han.h \
coll_han_trigger.h \
coll_han_algorithms.h \
coll_han_alltoall.c \
coll_han_alltoallv.c \
coll_han_dynamic.h \
coll_han_dynamic_file.h \
coll_han_barrier.c \
Expand Down
20 changes: 20 additions & 0 deletions ompi/mca/coll/han/coll_han.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ typedef struct mca_coll_han_op_module_name_t {
mca_coll_han_op_up_low_module_name_t scatter;
mca_coll_han_op_up_low_module_name_t scatterv;
mca_coll_han_op_up_low_module_name_t alltoall;
mca_coll_han_op_up_low_module_name_t alltoallv;
} mca_coll_han_op_module_name_t;

/**
Expand Down Expand Up @@ -260,6 +261,11 @@ typedef struct mca_coll_han_component_t {
/* alltoall: parallel stages */
int32_t han_alltoall_pstages;

/* low level module for alltoallv */
uint32_t han_alltoallv_low_module;
int64_t han_alltoallv_smsc_avg_send_limit;
double han_alltoallv_smsc_noncontig_activation_limit;


/* name of the modules */
mca_coll_han_op_module_name_t han_op_module_name;
Expand All @@ -286,6 +292,8 @@ typedef struct mca_coll_han_component_t {

/* Define maximum dynamic errors printed by rank 0 with a 0 verbosity level */
int max_dynamic_errors;

opal_free_list_t pack_buffers;
} mca_coll_han_component_t;

/*
Expand All @@ -297,6 +305,7 @@ typedef struct mca_coll_han_single_collective_fallback_s
union
{
mca_coll_base_module_alltoall_fn_t alltoall;
mca_coll_base_module_alltoallv_fn_t alltoallv;
mca_coll_base_module_allgather_fn_t allgather;
mca_coll_base_module_allgatherv_fn_t allgatherv;
mca_coll_base_module_allreduce_fn_t allreduce;
Expand All @@ -319,6 +328,7 @@ typedef struct mca_coll_han_single_collective_fallback_s
typedef struct mca_coll_han_collectives_fallback_s
{
mca_coll_han_single_collective_fallback_t alltoall;
mca_coll_han_single_collective_fallback_t alltoallv;
mca_coll_han_single_collective_fallback_t allgather;
mca_coll_han_single_collective_fallback_t allgatherv;
mca_coll_han_single_collective_fallback_t allreduce;
Expand Down Expand Up @@ -384,6 +394,9 @@ OBJ_CLASS_DECLARATION(mca_coll_han_module_t);
#define previous_alltoall fallback.alltoall.alltoall
#define previous_alltoall_module fallback.alltoall.module

#define previous_alltoallv fallback.alltoallv.alltoallv
#define previous_alltoallv_module fallback.alltoallv.module

#define previous_allgather fallback.allgather.allgather
#define previous_allgather_module fallback.allgather.module

Expand Down Expand Up @@ -440,6 +453,7 @@ OBJ_CLASS_DECLARATION(mca_coll_han_module_t);
HAN_UNINSTALL_COLL_API(COMM, HANM, allgather); \
HAN_UNINSTALL_COLL_API(COMM, HANM, allgatherv); \
HAN_UNINSTALL_COLL_API(COMM, HANM, alltoall); \
HAN_UNINSTALL_COLL_API(COMM, HANM, alltoallv); \
han_module->enabled = false; /* entire module set to pass-through from now on */ \
} while(0)

Expand Down Expand Up @@ -503,6 +517,9 @@ int
mca_coll_han_alltoall_intra_dynamic(ALLTOALL_BASE_ARGS,
mca_coll_base_module_t *module);
int
mca_coll_han_alltoallv_intra_dynamic(ALLTOALLV_BASE_ARGS,
mca_coll_base_module_t *module);
int
mca_coll_han_allgather_intra_dynamic(ALLGATHER_BASE_ARGS,
mca_coll_base_module_t *module);
int
Expand Down Expand Up @@ -566,4 +583,7 @@ static inline struct mca_smsc_endpoint_t *mca_coll_han_get_smsc_endpoint (struct
return (struct mca_smsc_endpoint_t *) proc->proc_endpoints[OMPI_PROC_ENDPOINT_TAG_SMSC];
}

#define COLL_HAN_PACKBUF_PAYLOAD_BYTES (128*1024)


#endif /* MCA_COLL_HAN_EXPORT_H */
4 changes: 4 additions & 0 deletions ompi/mca/coll/han/coll_han_algorithms.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ mca_coll_han_algorithm_value_t* mca_coll_han_available_algorithms[COLLCOUNT] =
{"smsc", (fnptr_t)&mca_coll_han_alltoall_using_smsc}, // 2-level
{ 0 }
},
[ALLTOALLV] = (mca_coll_han_algorithm_value_t[]){
{"smsc", (fnptr_t)&mca_coll_han_alltoallv_using_smsc}, // 2-level
{ 0 }
},
};

int
Expand Down
5 changes: 5 additions & 0 deletions ompi/mca/coll/han/coll_han_algorithms.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,5 +214,10 @@ int
mca_coll_han_alltoall_using_smsc(ALLTOALL_BASE_ARGS,
mca_coll_base_module_t *module);

/* Alltoallv */
int
mca_coll_han_alltoallv_using_smsc(ALLTOALLV_BASE_ARGS,
mca_coll_base_module_t *module);


#endif
Loading
Loading