Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accelerator/rocm: adjust rocm mca parameter names #12721

Merged
merged 2 commits into from
Aug 6, 2024
Merged

accelerator/rocm: adjust rocm mca parameter names #12721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d11393
accelerator/rocm: adjust rocm mca parameter names
edgargabriel Jul 29, 2024
b44ecf0
accelerator/ze: adjust parameter names
edgargabriel Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 36 additions & 22 deletions opal/mca/accelerator/rocm/accelerator_rocm_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,38 +130,52 @@ static int accelerator_rocm_close(void)

static int accelerator_rocm_component_register(void)
{
int var_id;

/* Set verbosity in the rocm related code. */
opal_accelerator_rocm_verbose = 0;
(void) mca_base_var_register("ompi", "mpi", "accelerator_rocm", "verbose",
"Set level of rocm verbosity", MCA_BASE_VAR_TYPE_INT, NULL,
0, 0, OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_verbose);
var_id = mca_base_component_var_register (&mca_accelerator_rocm_component.super.base_version,
"verbose", "Set level of verbosity of rocm component",
MCA_BASE_VAR_TYPE_INT, NULL, 0,
0, OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_verbose);
(void) mca_base_var_register_synonym (var_id, "ompi", "mpi", "accelerator_rocm", "verbose",
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);

/* Switching point between using memcpy and hipMemcpy* functions. */
opal_accelerator_rocm_memcpyD2H_limit = 1024;
(void) mca_base_var_register("ompi", "mpi", "accelerator_rocm", "memcpyD2H_limit",
"Max. msg. length to use memcpy instead of hip functions "
"for device-to-host copy operations",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_memcpyD2H_limit);

var_id = mca_base_component_var_register (&mca_accelerator_rocm_component.super.base_version,
"memcpyD2H_limit",
"Max. msg. length to use memcpy instead of hip functions "
"for device-to-host copy operations",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_memcpyD2H_limit);
(void) mca_base_var_register_synonym (var_id, "ompi", "mpi", "accelerator_rocm", "memcpyD2H_limit",
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);

/* Switching point between using memcpy and hipMemcpy* functions. */
opal_accelerator_rocm_memcpyH2D_limit = 1048576;
(void) mca_base_var_register("ompi", "mpi", "accelerator_rocm", "memcpyH2D_limit",
"Max. msg. length to use memcpy instead of hip functions "
"for host-to-device copy operations",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_memcpyH2D_limit);
var_id = mca_base_component_var_register (&mca_accelerator_rocm_component.super.base_version,
"memcpyH2D_limit",
"Max. msg. length to use memcpy instead of hip functions "
"for host-to-device copy operations",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_memcpyH2D_limit);
(void) mca_base_var_register_synonym (var_id, "ompi", "mpi", "accelerator_rocm", "memcpyH2D_limit",
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);

/* Use this flag to test async vs sync copies */
opal_accelerator_rocm_memcpy_async = 0;
(void) mca_base_var_register("ompi", "mpi", "accelerator_rocm", "memcpy_async",
"Set to 1 to force using hipMemcpyAsync instead of hipMemcpy",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0, OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &opal_accelerator_rocm_memcpy_async);

var_id = mca_base_component_var_register (&mca_accelerator_rocm_component.super.base_version,
"memcpy_async",
"Set to 1 to force using hipMemcpyAsync instead of hipMemcpy",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0, OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_rocm_memcpy_async);
(void) mca_base_var_register_synonym (var_id, "ompi", "mpi", "accelerator_rocm", "memcpy_async",
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);
return OPAL_SUCCESS;
}

Expand Down
13 changes: 9 additions & 4 deletions opal/mca/accelerator/ze/accelerator_ze_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,17 @@ static int accelerator_ze_close(void)

static int accelerator_ze_component_register(void)
{
int var_id;

/* Set verbosity in the ze related code. */
opal_accelerator_ze_verbose = 0;
(void) mca_base_var_register("ompi", "mpi", "accelerator_ze", "verbose",
"Set level of ze verbosity", MCA_BASE_VAR_TYPE_INT, NULL,
0, 0, OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_ze_verbose);
var_id = mca_base_component_var_register(&mca_accelerator_ze_component.super.base_version,
"verbose", "Set level of ze verbosity",
MCA_BASE_VAR_TYPE_INT, NULL,
0, 0, OPAL_INFO_LVL_9, MCA_BASE_VAR_SCOPE_READONLY,
&opal_accelerator_ze_verbose);
(void) mca_base_var_register_synonym (var_id, "ompi", "mpi", "accelerator_ze", "verbose",
MCA_BASE_VAR_SYN_FLAG_DEPRECATED);

return OPAL_SUCCESS;
}
Expand Down
Loading