Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portals4: use PtlHandleIsEqual() to compare handles #12713

Conversation

tkordenbrock
Copy link
Member

@tkordenbrock tkordenbrock commented Jul 25, 2024

The Portals4 standard requires the use of PtlHandleIsEqual() instead of the (in)equality operatror, because a handle may be a compound data type that cannot be directly compared.

Thanks to @nbartelheimer for the bug report.

@wenduwan
Copy link
Contributor

@tkordenbrock Curious are you planning to backport this to v5.0.x?

@tkordenbrock
Copy link
Member Author

@tkordenbrock Curious are you planning to backport this to v5.0.x?

Yes, this one will be backported to v5.0.x.

The Portals4 standard requires the use of PtlHandleIsEqual()
instead of the (in)equality operatror, because a handle may
be a compound data type that cannot be directly compared.

Signed-off-by: Todd Kordenbrock <[email protected]>
@tkordenbrock tkordenbrock force-pushed the topic/main/portals4-use-PtlHandleIsEqual branch from cefee2e to 1d891d3 Compare August 13, 2024 13:10
Copy link
Contributor

@mdosanjh mdosanjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is fairly straightforward and looks good.

@tkordenbrock tkordenbrock merged commit afa9d65 into open-mpi:main Aug 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants