Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for generalized requests #12392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix error handling for generalized requests #12392

wants to merge 4 commits into from

Commits on Aug 14, 2024

  1. request: Fix multiple calls to ompi_request_complete() 

    A second call to ompi_request_complete() segfaults. Make it mostly an
non-op. Alternatively, the second invocation could generate an error, but
let's play safe for now.

Signed-off-by: Lisandro Dalcin <[email protected]>
    @dalcinl @wenduwan
    dalcinl authored and wenduwan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    59c2af8 View commit details
    Browse the repository at this point in the history

  2. request: Improve MPI_Request_free() error handling 

    If ompi_request_free() fails, use the ompi_errhandler_request_invoke()
machinery used in the wait/test routines. This will have the side-effect
of attempting to free the request a second time.

Signed-off-by: Lisandro Dalcin <[email protected]>
    @dalcinl @wenduwan
    dalcinl authored and wenduwan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    16c6381 View commit details
    Browse the repository at this point in the history

  3. grequest: Fix MPI_Request_get_status() to propagate errors form query_fn 

    Signed-off-by: Lisandro Dalcin <[email protected]>
    @dalcinl @wenduwan
    dalcinl authored and wenduwan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    adb640d View commit details
    Browse the repository at this point in the history

  4. grequest: Fix propagation of errors from callback functions. 

    Signed-off-by: Lisandro Dalcin <[email protected]>
    @dalcinl @wenduwan
    dalcinl authored and wenduwan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    40a500d View commit details
    Browse the repository at this point in the history