Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] fix albumentation typo #3259

Closed
wants to merge 1 commit into from

Conversation

ModestYjx
Copy link

@ModestYjx ModestYjx commented Aug 14, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

There is a typing error in the mmsegmentation document that supports estimation.

Modification

Fix the typing error.
from "pip install-U albumentations –no-binary qudida,albumentations " to "pip install -U albumentations --no-binary qudida,albumentations".

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ModestYjx seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@xiexinch
Copy link
Collaborator

Hi @ModestYjx,
Thanks for your contribution, please sign the CLA, then I'll merge this PR soon.

@xiexinch xiexinch changed the title [docs] fix albumentation typo [Doc] fix albumentation typo Aug 15, 2023
@OpenMMLab-Assistant-004

Hi @ModestYjx,

We'd like to express our appreciation for your valuable contributions to the mmsegmentation. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@ModestYjx
Copy link
Author

I have signed the CLA. @xiexinch

@xiexinch
Copy link
Collaborator

Hi @ModestYjx,
It shows that you've not signed it. You should add the email used to commit code on your local machine to your GitHub account.

@xiexinch
Copy link
Collaborator

Hi @ModestYjx,
Thanks for your contribution. We are very sorry, there is no longer any maintenance on the 0.x branch, so this pr will be closed.

@xiexinch xiexinch closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants