Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbbox_overlaps does not accept eps as parameter #947

Open
wants to merge 1 commit into
base: dev-1.x
Choose a base branch
from

Conversation

mawanda-jun
Copy link

Motivation

The function `mmrotate.structures.bbox.bbox_overlaps.rbbox_overlaps does not accept eps as parameter, so it shouldn't be passed here. I think it should be passed until here because:

  • At this point, compatibility with other BaseBoxes is kept;
  • The problem affects the RBbox.

Modification

Delete eps parameter to be passed to the rbbox_overlaps function.

BC-breaking (Optional)

It shouldn't.

Use cases (Optional)

No new features, just bugfixing.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues. -> DONE.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness. -> DONE
  3. The documentation has been modified accordingly, like docstring or example tutorials. -> DONE

The function `mmrotate.structures.bbox.bbox_overlaps.rbbox_overlaps does not accept eps as parameter, so it shouldn't be passed here. I think it should be passed until here because:
- At this point, compatibility with other BaseBoxes is kept;
- The problem affects the RBbox.
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants