Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set torchserve version to 0.7.1 for compatibility #1815

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

joaquincabezas
Copy link

Motivation

In the Dockerfile and the mmpretrain2torchserve.py files there is no clear reference to any version of torch-model-archiver, it is just the latest (pip install torchserve torch-model-archiver, currently it is 0.8.2), however from 0.8.0 there is a change that breaks the script for exporting to TorchServe MAR file.

To reproduce the error, simply install torch-model-archiver with any version higher that 0.7.1 (i.e. pip install torchserve==0.8.0 torch-model-archiver==0.8.0).

An error coming from the line 68 of "tools/torchserve/mmpretrain2torchserve.py" (manifest = ModelExportUtils.generate_manifest_json(args)) will raise. The error is:

AttributeError: 'Namespace' object has no attribute 'config_file'

Modification

To avoid this, the developer needs to set the version to 0.7.1. I suggest setting this in the Dockerfile and the script.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

LALBJ and others added 8 commits August 23, 2023 10:45
…pen-mmlab#1756)

* feat: impelemt DINO

* chore: delete debug code

* chore: impplement pre-commit

* fix: fix imported package

* chore: pre-commit check
…open-mmlab#1774)

* add new config adapting MobileNetV2,V3

* add base model config for mobile net v3, modified all training configs of mobile net v3 inherit from the base model config

* removed directory _base_/models/mobilenet_v3
* zero-shot CLIP

* modify zero-shot clip config

* add in1k_sub_prompt(8 prompts) for improvement

* add some annotations doc

* clip base class & clip_zs sub-class

* some modifications of details after review

* convert into and use mmpretrain-vit

* modify names of some files and directories
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants