Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add chartqa #1668

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

wangbo-zhao
Copy link
Contributor

@wangbo-zhao wangbo-zhao commented Jun 27, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 36.34% and project coverage change: -2.84 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (c20197f) 65.33%.

❗ Current head c20197f differs from pull request most recent head 0cdbaca. Consider uploading reports for the commit 0cdbaca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1668      +/-   ##
==========================================
- Coverage   68.16%   65.33%   -2.84%     
==========================================
  Files         295      331      +36     
  Lines       23372    25679    +2307     
  Branches     3713     4093     +380     
==========================================
+ Hits        15932    16777     +845     
- Misses       6880     8291    +1411     
- Partials      560      611      +51     
Flag Coverage Δ
unittests 65.33% <36.34%> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/apis/feature_extractor.py 37.50% <0.00%> (ø)
mmpretrain/apis/image_caption.py 30.64% <0.00%> (ø)
mmpretrain/apis/image_retrieval.py 21.42% <0.00%> (ø)
mmpretrain/apis/visual_grounding.py 27.53% <0.00%> (ø)
mmpretrain/apis/visual_question_answering.py 25.67% <0.00%> (ø)
mmpretrain/datasets/__init__.py 59.09% <0.00%> (-15.20%) ⬇️
mmpretrain/datasets/chartqa.py 0.00% <0.00%> (ø)
mmpretrain/datasets/flickr30k_caption.py 0.00% <0.00%> (ø)
mmpretrain/datasets/flickr30k_retrieval.py 0.00% <0.00%> (ø)
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
... and 63 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wangbo-zhao wangbo-zhao changed the title add chartqa [Feature] add chartqa Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant