Skip to content

Commit

Permalink
[GitHub] Update issue template and remove general question template. (#…
Browse files Browse the repository at this point in the history
…1087)

* [CI] Fix CI error from timm and PyTorch version. (#1076)

* [GitHub] Update issue template and remove general question template.

* Add branch check dropdown options.
  • Loading branch information
mzr1996 committed Oct 20, 2022
1 parent 91b85bb commit a9489f6
Show file tree
Hide file tree
Showing 8 changed files with 64 additions and 69 deletions.
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/1_bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ body:
If you have already identified the reason, we strongly appreciate you creating a new PR according to [the tutorial](https://mmclassification.readthedocs.io/en/master/community/CONTRIBUTING.html)!
If you need our help, please fill in the following form to help us to identify the bug.
- type: dropdown
id: version
attributes:
label: Branch
description: Which branch/version are you using?
options:
- master branch (0.24 or other 0.x version)
- 1.x branch (1.0.0rc2 or other 1.x version)
validations:
required: true

- type: textarea
id: describe
validations:
Expand Down
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/2_feature-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ body:
value: |
If you have already implemented the feature, we strongly appreciate you creating a new PR according to [the tutorial](https://mmclassification.readthedocs.io/en/master/community/CONTRIBUTING.html)!
- type: dropdown
id: version
attributes:
label: Branch
description: Which branch/version are you using?
options:
- master branch (0.24 or other 0.x version)
- 1.x branch (1.0.0rc2 or other 1.x version)
validations:
required: true

- type: textarea
id: describe
validations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ body:
如果你已经有了解决方案,我们非常欢迎你直接创建一个新的 PR 来解决这个问题。创建 PR 的流程可以参考[文档](https://mmclassification.readthedocs.io/zh_CN/master/community/CONTRIBUTING.html)。
如果你需要我们的帮助,请填写以下内容帮助我们定位 Bug。
- type: dropdown
id: version
attributes:
label: 分支
description: 你正在使用的分支/版本是哪个?
options:
- master 分支 (0.24 或其他 0.x 版本)
- 1.x 分支 (1.0.0rc2 或其他 1.x 版本)
validations:
required: true

- type: textarea
id: describe
validations:
Expand Down
24 changes: 0 additions & 24 deletions .github/ISSUE_TEMPLATE/3_general-questions.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@ body:
如果你已经实现了该功能,我们非常欢迎你直接创建一个新的 PR 来解决这个问题。创建 PR 的流程可以参考[文档](https://mmclassification.readthedocs.io/zh_CN/master/community/CONTRIBUTING.html)。
- type: dropdown
id: version
attributes:
label: 分支
description: 你正在使用的分支/版本是哪个?
options:
- master 分支 (0.24 或其他 0.x 版本)
- 1.x 分支 (1.0.0rc2 或其他 1.x 版本)
validations:
required: true

- type: textarea
id: describe
validations:
Expand Down
29 changes: 0 additions & 29 deletions .github/ISSUE_TEMPLATE/6_general-questions_zh.yml

This file was deleted.

6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
blank_issues_enabled: false

contact_links:
- name: 📚 MMClassification Documentation
- name: 📚 MMClassification Documentation (官方文档)
url: https://mmclassification.readthedocs.io/en/latest/
about: Check if your question is answered in docs
- name: 💬 Forum
- name: 💬 General questions (寻求帮助)
url: https://github.com/open-mmlab/mmclassification/discussions
about: Ask general usage questions and discuss with other MMClassification community members
- name: 🌐 Explore OpenMMLab
- name: 🌐 Explore OpenMMLab (官网)
url: https://openmmlab.com/
about: Get know more about OpenMMLab
30 changes: 17 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,24 +29,18 @@ concurrency:
cancel-in-progress: true

jobs:
build_without_timm:
build_with_timm:
runs-on: ubuntu-latest
env:
UBUNTU_VERSION: ubuntu1804
strategy:
matrix:
python-version: [3.6]
torch: [1.5.0, 1.8.0, 1.9.0]
torch: [1.8.0]
include:
- torch: 1.5.0
torchvision: 0.6.0
torch_major: 1.5.0
- torch: 1.8.0
torchvision: 0.9.0
torch_major: 1.8.0
- torch: 1.9.0
torchvision: 0.10.0
torch_major: 1.9.0

steps:
- uses: actions/checkout@v2
Expand All @@ -63,13 +57,26 @@ jobs:
- name: Install mmcls dependencies
run: |
pip install -r requirements.txt
- name: Install timm
run: |
pip install timm
- name: Build and install
run: |
rm -rf .eggs
pip install -e . -U
- name: Run unittests
run: |
pytest tests/ --ignore tests/test_models/test_backbones/test_timm_backbone.py
coverage run --branch --source mmcls -m pytest tests/
coverage xml
coverage report -m --omit="mmcls/utils/*","mmcls/apis/*"
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
with:
file: ./coverage.xml
flags: unittests
env_vars: OS,PYTHON
name: codecov-umbrella
fail_ci_if_error: false

build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -130,16 +137,13 @@ jobs:
- name: Install mmcls dependencies
run: |
pip install -r requirements.txt
- name: Install timm
run: |
pip install timm
- name: Build and install
run: |
rm -rf .eggs
pip install -e . -U
- name: Run unittests and generate coverage report
run: |
coverage run --branch --source mmcls -m pytest tests/
coverage run --branch --source mmcls -m pytest tests/ -k "not timm"
coverage xml
coverage report -m --omit="mmcls/utils/*","mmcls/apis/*"
- name: Upload coverage to Codecov
Expand Down

0 comments on commit a9489f6

Please sign in to comment.