Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bug https://github.com/open-mmlab/mmaction2/issues/2459 #2474

Merged
merged 13 commits into from
Jun 29, 2023
Merged

[Fix] Fix bug https://github.com/open-mmlab/mmaction2/issues/2459 #2474

merged 13 commits into from
Jun 29, 2023

Conversation

mareksubocz
Copy link
Contributor

@mareksubocz mareksubocz commented Jun 20, 2023

Fixes a bug that was found and solved in mmaction2 repository: open-mmlab/mmaction2#2459

Motivation

A bug was found that made pose inference on video throw an error when there were no human detections in any frame.

Modification

An if conditional was broadened to included 0-length arrays

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023

CLA assistant check
All committers have signed the CLA.

@Tau-J Tau-J changed the base branch from main to dev-1.x June 21, 2023 02:45
@Tau-J Tau-J changed the title Fix bug https://github.com/open-mmlab/mmaction2/issues/2459 [Fix] Fix bug https://github.com/open-mmlab/mmaction2/issues/2459 Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (93119ae) 81.99% compared to head (f07a798) 82.01%.

❗ Current head f07a798 differs from pull request most recent head 8c45ac1. Consider uploading reports for the commit 8c45ac1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2474      +/-   ##
===========================================
+ Coverage    81.99%   82.01%   +0.01%     
===========================================
  Files          232      232              
  Lines        13638    13638              
  Branches      2319     2319              
===========================================
+ Hits         11183    11185       +2     
+ Misses        1919     1915       -4     
- Partials       536      538       +2     
Flag Coverage Δ
unittests 82.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference.py 76.69% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OpenMMLab-Assistant-004

Hi @mareksubocz,

We'd like to express our appreciation for your valuable contributions to the mmpose. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@Tau-J
Copy link
Collaborator

Tau-J commented Jun 29, 2023

Hi @mareksubocz , thanks for your contribution. Could you please sign the CLA?

@mareksubocz
Copy link
Contributor Author

Hi @mareksubocz , thanks for your contribution. Could you please sign the CLA?

No problem :)

@Tau-J Tau-J merged commit fe4dec7 into open-mmlab:dev-1.x Jun 29, 2023
8 of 9 checks passed
@mareksubocz mareksubocz deleted the patch-2 branch June 29, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants