Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Config File to Added WandBLogger Hook Details #1606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nourollah
Copy link

Motivation

To better use MMPose functionality.

Modification

It's a few lines modified to add more logger hooks to docs.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

interval=50, # Interval to print the log
hooks=[
dict(type='TextLoggerHook', by_epoch=False), # The logger used to record the training process
dict(type='TensorboardLoggerHook', by_epoch=False), # The Tensorboard logger to record log offline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why by_epoch is set to False by default?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this parameter to show the possibility of changing it to True or False to those who want to use it. It is possible to give it the True default value, I don't have any special reason to use the False value as default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better not to change the default setting here. To show the options, we can add by_epoch=True here.

@ly015 ly015 requested a review from jin-s13 September 2, 2022 13:48
@jin-s13
Copy link
Collaborator

jin-s13 commented Sep 8, 2022

截屏2022-09-08 下午2 21 39

Could you help check again the display of the markdown? Some part of texts are not correctly displayed.


```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent seems incorrect here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants