Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger_hook.py #1449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InakiRaba91
Copy link

@InakiRaba91 InakiRaba91 commented Dec 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

I believe the metrics computed during a test run to evaluate a model are not being logged to the visualizer (i.e.: MLflow).

Modification

It consists of simply calling the add_scalars method of the visualizer to log them

Use cases (Optional)

It would be desirable to visualize the test metrics on MLflow for instance.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023

CLA assistant check
All committers have signed the CLA.

@HAOCHENYE
Copy link
Collaborator

Thanks for your contribution! Please sign the CLA first 😆. This modification could be weird if you use the TensorBoardVisbackend. I think it could be better to add a parameter to LoggerHook to control whether to use the visualizer to write data during testing

@InakiRaba91
Copy link
Author

Could you elaborate on what would be problematic for TensorBoardVisbackend? I'm not sure I follow, it also implements the VisBackend interface and provides the add_scalars method

@ccomkhj
Copy link

ccomkhj commented Jul 14, 2024

Looking forward to this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants