Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert bboxes to numpy.ndarray in InstanceData for Detection Task #11961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Archie2035
Copy link

Motivation

The motivation for this PR is to convert the bboxes attribute in the gt_instances object from a list format to numpy.ndarray. This change ensures the data is in a consistent and efficient format for further processing in deep learning models.

Modification

The modification in this PR changes the code related to gt_instances.bboxes and gt_instances.labels assignment from list comprehensions to numpy.ndarray. Specifically, it uses numpy.array to convert the list of bounding boxes and labels into numpy.ndarray.

Modified code:

import numpy as np
from mmdet.structures import InstanceData

if task == 'det':
    gt_instances = InstanceData()
    gt_instances.bboxes = np.array([d['bbox'] for d in data_info['gt_instances']])

BC-breaking (Optional)

There are no backward-compatibility-breaking changes introduced by this modification. The modified code only affects the internal representation of bboxes and labels, but the external interface and expected behavior of the code remain unchanged.

Use cases (Optional)

This PR does not introduce a new feature but refines the existing functionality. However, if there are any internal functions or modules relying on the old list format, ensure they are updated to handle numpy.ndarray appropriately.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants