Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLTK Download and add Verbose Flag for GLIP #11741

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Pikus16
Copy link

@Pikus16 Pikus16 commented May 24, 2024

Motivation

Current NLTK download is 1) set in an unexpected directory, and 2) can't be set to quiet with a flag.

Modification

This PR adds both those changes by 1) changing download_dir='~/nltk_data' to download_dir=expanduser('~/nltk_data'), and 2) adding in a verbosity flag to allow to set quiet=True.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented May 24, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants