Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci #2609

Merged
merged 2 commits into from
Dec 25, 2023
Merged

fix ci #2609

merged 2 commits into from
Dec 25, 2023

Conversation

RunningLeon
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (c4dc10d) 48.50% compared to head (7b4dcf4) 48.38%.
Report is 14 commits behind head on main.

Files Patch % Lines
mmdeploy/codebase/mmpose/models/heads/rtmo_head.py 23.80% 32 Missing ⚠️
...oy/codebase/mmdet/models/roi_heads/htc_roi_head.py 33.33% 12 Missing ⚠️
...oy/codebase/mmpose/models/heads/yolox_pose_head.py 7.69% 12 Missing ⚠️
...loy/codebase/mmpose/deploy/pose_detection_model.py 28.57% 8 Missing and 2 partials ⚠️
mmdeploy/codebase/base/task.py 0.00% 1 Missing and 1 partial ⚠️
...oy/codebase/mmdet/deploy/object_detection_model.py 0.00% 2 Missing ⚠️
mmdeploy/backend/onnxruntime/wrapper.py 0.00% 1 Missing ⚠️
mmdeploy/codebase/mmpose/deploy/pose_detection.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
- Coverage   48.50%   48.38%   -0.12%     
==========================================
  Files         355      357       +2     
  Lines       13795    13850      +55     
  Branches     2050     2046       -4     
==========================================
+ Hits         6691     6702      +11     
- Misses       6653     6693      +40     
- Partials      451      455       +4     
Flag Coverage Δ
unittests 48.38% <31.42%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2023

CLA assistant check
All committers have signed the CLA.

@RunningLeon RunningLeon added the CI label Dec 25, 2023
@RunningLeon RunningLeon merged commit 1e79b48 into open-mmlab:main Dec 25, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants