Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support yolox-pose sdk #2240

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

huayuan4396
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage is 26.92% of modified lines.

Files Changed Coverage
...loy/codebase/mmpose/deploy/pose_detection_model.py 16.00%
mmdeploy/codebase/mmpose/deploy/pose_detection.py 37.03%

📢 Thoughts on this report? Let us know!.

@RunningLeon
Copy link
Collaborator

@irexyc @grimoire hi, guys, any comments on this PR? @lzhangzz hi, could you take look at this PR and check if it has bad impact on pose_tracker part? thanks.

@irexyc
Copy link
Collaborator

irexyc commented Sep 7, 2023

I think the change of mmdeploy_pose_detection_t will affect jave/c# api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants