fixed issue #2470 (some windows support for ffmpeg calls)

mmcv/__init__.py

@@ -1,26 +0,0 @@
-# Copyright (c) OpenMMLab. All rights reserved.
-# flake8: noqa
-import warnings
-
-from .arraymisc import *
-from .fileio import *
-from .image import *
-from .utils import *
-from .version import *
-from .video import *
-from .visualization import *
-
-# The following modules are not imported to this level, so mmcv may be used
-# without PyTorch.
-# - runner
-# - parallel
-# - op
-# - device
-
-warnings.warn(
-    'On January 1, 2023, MMCV will release v2.0.0, in which it will remove '
-    'components related to the training process and add a data transformation '
-    'module. In addition, it will rename the package names mmcv to mmcv-lite '
-    'and mmcv-full to mmcv. '
-    'See https://github.com/open-mmlab/mmcv/blob/master/docs/en/compatibility.md '
-    'for more details.')

mmcv/utils/misc.py

@@ -8,6 +8,7 @@
 from importlib import import_module
 from inspect import getfullargspec
 from itertools import repeat
+import platform
 
 
 # From PyTorch internals
@@ -251,10 +252,16 @@ def _check_py_package(package):
 
 
 def _check_executable(cmd):
-    if subprocess.call(f'which {cmd}', shell=True) != 0:
-        return False
-    else:
-        return True
+    if platform.system() == 'Linux':
+        if subprocess.call(f'which {cmd}', shell=True) != 0:
+            return False
+        else:
+            return True
+    if platform.system() == 'Windows':
+        if subprocess.call(f'where {cmd}', shell=True) != 0:
+            return False
+        else:
+            return True
 
 
 def requires_package(prerequisites):

mmcv/video/__init__.py

@@ -1,5 +1,5 @@
 # Copyright (c) OpenMMLab. All rights reserved.
-from .io import Cache, VideoReader, frames2video
+from .mm_io import Cache, VideoReader, frames2video
 from .optflow import (dequantize_flow, flow_from_bytes, flow_warp, flowread,
                       flowwrite, quantize_flow, sparse_flow_from_bytes)
 from .processing import concat_video, convert_video, cut_video, resize_video

mmcv/video/io.py → mmcv/video/mm_io.py

@@ -7,6 +7,7 @@
                  CAP_PROP_FRAME_HEIGHT, CAP_PROP_FRAME_WIDTH,
                  CAP_PROP_POS_FRAMES, VideoWriter_fourcc)
 
+# if error here, please add mmcv_forked/ to PYTHON_PATH
 from mmcv.utils import (check_file_exist, mkdir_or_exist, scandir,
                         track_progress)
 
@@ -38,6 +39,12 @@ def get(self, key, default=None):
         val = self._cache[key] if key in self._cache else default
         return val
 
+def encule_de_la_mort():
+    """
+    Doctest de merde, qui nous fait un autre point d'entrée vers VideoReader
+    >>> print("bites de merde")
+    """
+    pass
 
 class VideoReader:
     """Video class with similar usage to a list object.
@@ -49,15 +56,18 @@ class VideoReader:
     Cache is used when decoding videos. So if the same frame is visited for
     the second time, there is no need to decode again if it is stored in the
     cache.
+    # import dependencies.mmcv_forked.mmcv.video.io, dependencies.mmcv_forked.mmcv.visualization
+    # from dependencies.mmcv_forked.mmcv.video import VideoReader
 
     Examples:
-        >>> import mmcv
-        >>> v = mmcv.VideoReader('sample.mp4')
+        >>> import dependencies.mmcv_forked.mmcv as mmcv
+        >>> import dependencies.mmcv_forked.mmcv.video
+        >>> import dependencies.mmcv_forked.mmcv.visualization
+        >>> from path_config import PATHS
+        >>> v = mmcv.video.VideoReader(str(PATHS.examples_vid / 'in.mp4'))
         >>> len(v)  # get the total frame number with `len()`
-        120
-        >>> for img in v:  # v is iterable
-        >>>     mmcv.imshow(img)
-        >>> v[5]  # get the 6th frame
+        8
+        >>> mmcv.visualization.imshow(v[5], wait_time=1)  # get the 6th frame
     """
 
     def __init__(self, filename, cache_capacity=10):

mmcv/video/processing.py

@@ -45,8 +45,8 @@ def convert_video(in_file: str,
             options.append(f'-loglevel {v}')
         else:
             options.append(f'-{k} {v}')
-    cmd = f'ffmpeg -y {pre_options} -i {in_file} {" ".join(options)} ' \
-          f'{out_file}'
+    cmd = f'ffmpeg -y {pre_options} -i "{in_file}" {" ".join(options)} ' \
+          f'"{out_file}"'
     if print_cmd:
         print(cmd)
     subprocess.call(cmd, shell=True)