Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Contribution Guideline for Amphion #92

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

HarryHe11
Copy link
Collaborator

@HarryHe11 HarryHe11 commented Jan 6, 2024

✨ Description:

Adding contribution guidelines, pull request template, and code of conduct.

🚧 Related Issues:

No related issues.

πŸ‘¨β€πŸ’» Changes Proposed:

  • [1] Add contribution guidelines (CONTRIBUTING.md)
  • [2] Add pull request template (pull_request_template.md)
  • [3] Add code of conduct (CODE_OF_CONDUCT.md)
  • [4] Updated main README.md

πŸ§‘β€πŸ€β€πŸ§‘ Who can review?

@RMSnow @lmxue

πŸ›  TODO

No TODO.

βœ… Checklist:

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@HarryHe11 HarryHe11 requested review from RMSnow and lmxue January 6, 2024 11:48
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

.github/pull_request_template.md Show resolved Hide resolved
@HarryHe11
Copy link
Collaborator Author

Nice work!

Hi Xueyao, thank you so much for reviewing my pr. I've updated this pr according to your feedback, please check the latest commit!

Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts. Please check the comment.

@HarryHe11
Copy link
Collaborator Author

Thanks for your efforts. Please check the comment.

Hi Liumeng, thank you so much for reviewing my pr. I've resolved your comments. Please check the latest commit!

@HarryHe11 HarryHe11 requested a review from RMSnow January 9, 2024 08:54
@RMSnow RMSnow merged commit 20b5fad into open-mmlab:main Jan 9, 2024
1 check passed
@HarryHe11 HarryHe11 deleted the contribute_template branch January 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants