Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VALL-E new version release readme files and directory name #224

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Update VALL-E new version release readme files and directory name #224

merged 4 commits into from
Jun 25, 2024

Conversation

jiaqili3
Copy link
Collaborator

✨ Description

adding more readme info of our new VALL-E implementation, and align VALLE V2 folder name with other Amphion files.

🚧 Related Issues

None

👨‍💻 Changes Proposed

    • Change naming from "egs/tts/valle_v2" to "egs/tts/VALLE_V2" for naming consistency
    • Add intro to this model in "egs/tts/README.md"

🧑‍🤝‍🧑 Who Can Review?

@RMSnow

✅ Checklist

    • Code has been reviewed
    • Code complies with the project's code standards and best practices
    • Code has passed all tests
    • Code does not affect the normal use of existing features
    • Code has been commented properly
    • Documentation has been updated (if applicable)
    • Demo/checkpoint has been attached (if applicable)

RMSnow
RMSnow requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo.ipynb and example.wav are deleted by mistake?

@jiaqili3
Copy link
Collaborator Author

The demo.ipynb and example.wav are deleted by mistake?

Resolved. Thanks for the notice @RMSnow !

@RMSnow RMSnow self-requested a review June 25, 2024 06:24
RMSnow
RMSnow approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RMSnow RMSnow merged commit 5dfe9fd into open-mmlab:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMSnow RMSnow RMSnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaqili3 @RMSnow