Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints by ruff scanning #197

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Nugine
Copy link

@Nugine Nugine commented May 4, 2024

✨ Description

This PR fixes some code style problems in the codebase.

🚧 Related Issues

#195

πŸ‘¨β€πŸ’» Changes Proposed

See the commits

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

[Please use the '@' symbol to mention any community member who is free to review the PR once the tests have passed. Feel free to tag members or contributors who might be interested in your PR.]

IDK who I should mention. Is there any list?

πŸ›  TODO

There are too many occurences of import problems. Changing them may cause troubles.

ruff check --select F523,F401,E402,F403,F405,E741,F821,F841

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

Copy link
Collaborator

@Adorable-Qin Adorable-Qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Nugine Nugine mentioned this pull request May 7, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants