-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameFrameworkNx: Add member variables #141
GameFrameworkNx: Add member variables #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if there was more information used from the constructor but I'd be happy to merge with at least these 2 changes
@@ -7,6 +7,21 @@ | |||
|
|||
namespace sead | |||
{ | |||
|
|||
class DisplayBufferNvn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I prefer this over just an include though I don't think that should block this PR, @leoetlino I would like your opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did that from habit since we do that for smo
About adding more info: I can add more info from the ctor, but @MonsterDruide1 suggested just adding one line for a filler, so idk |
Having fillers is fine tbh, I just looked at the constructor myself and noticed a bunch of small details that could be included in this PR (floats, sead::SafeString, other structs/array memcpys) |
SMO's
al::GameFrameworkNx
requires thesead
one to have the correct size. Besides filling the struct with the correct size, I also added some names and types based on @MonsterDruide1 's structThis change is