Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WMT19 dataset configuration and inference code #1503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpa2001
Copy link
Contributor

@cpa2001 cpa2001 commented Sep 6, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

This pull request aims to introduce support for the WMT19 dataset within the opencompass framework. The WMT19 dataset is widely used for machine translation tasks, and by adding it to opencompass, we extend the framework’s coverage for benchmarking large models on translation tasks.

Modification

In this PR, I have added:

  1. A new dataset configuration file (wmt19.py) that defines the dataset loading and pre-processing for the WMT19 dataset.
  2. An inference script (wmt19_gen.py) that handles the evaluation of models on the WMT19 dataset, ensuring smooth integration with the opencompass benchmarking framework.
  3. Update __init__.py to upload wmt19 configs.

No major changes have been made to the existing framework structure. The new code strictly extends the dataset and inference capabilities without modifying any core components.

BC-breaking (Optional)

This PR does not introduce any backward compatibility issues. The changes are self-contained within the new dataset and inference files and do not affect the existing functionality of the opencompass framework.

Use cases (Optional)

This PR adds the WMT19 dataset to the opencompass framework. It can be used to evaluate large models on machine translation tasks, particularly between multiple language pairs supported by the WMT19 benchmark.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants