switch quoting library #491
Conversation
|
Hm, not sure about the open linter errors for running ESLint on my working copy presents that warning, only. In case it is fixing something locally, this does not result in a change accepted for commission by git CLI tool. |
There was a problem hiding this comment.
Seems like a lockfile version bump here.
I'll try updating this on main first to decrease the LOC in this PR.
| @@ -55,11 +55,11 @@ | |||
| "author": "Kimmo Brunfeldt", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@cepharum/quoting-db": "^1.2.0", | |||
There was a problem hiding this comment.
Seems like a fresh new package, would you be keen on hosting and maintaining it from the open-cli-tools org? Seems it'd fit perfectly ;)
| @@ -10,6 +10,8 @@ export class ExpandArguments implements CommandParser { | |||
| constructor(private readonly additionalArguments: string[]) {} | |||
|
|
|||
| parse(commandInfo: CommandInfo) { | |||
| const configuration = getShellConfigurationSync(); | |||
There was a problem hiding this comment.
Looked at the source of this function briefly, seems it defaults to the value of COMSPEC.
Since cmd.exe is hardcoded for windows (source below), should the same be done here?
Lines 17 to 18 in e52d984
fixing #487
The PR is replacing the generic approach in shell-quote library with a different one based on character-by-character tests I've made resulting in a different quoting library.