v1.10 Spec Changes for the L0 Loader #200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 10, 2024
nrspruit
commented
- Generated code changes for the Loader supporting L0 v1.10.0
- Added new metric handle generators
- Add support for zeInitDrivers
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
|
Hello @lisanna-dettwyler / @rwmcguir / @Jemale , This is the first draft of the v1.10 support, I still need to write tests for zeInitDrivers and expand the null driver for that testing, but this is the first working draft. |
| @@ -114,7 +114,7 @@ namespace ze_lib | |||
| // Check which drivers support the ze_driver_flag_t specified | |||
| // No need to check if only initializing sysman | |||
| bool requireDdiReinit = false; | |||
| result = zelLoaderDriverCheck(flags, &ze_lib::context->initialzeDdiTable.Global, &ze_lib::context->initialzesDdiTable.Global, &requireDdiReinit, sysmanOnly); | |||
| result = zelLoaderDriverCheck(flags, desc, &ze_lib::context->initialzeDdiTable.Global, &ze_lib::context->initialzesDdiTable.Global, &requireDdiReinit, sysmanOnly); | |||
There was a problem hiding this comment.
am I just now noticing that a lot of this function assumes ! DYNAMIC_LOAD_LOADER?
There was a problem hiding this comment.
yes, if we enable that option there will need to be a refactor.
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
zeInitDrivers
branch
from
07c4cb0
to
d25d48c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.