Skip to content
This repository has been archived by the owner on Aug 23, 2021. It is now read-only.

SpliceMachine Support #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SpliceMachine Support #185

wants to merge 2 commits into from

Conversation

Covariants
Copy link

Splicemachine team.

@apavlo apavlo changed the title Pull Request for Database Extra credit Project SpliceMachine Support Dec 16, 2017
apavlo
apavlo suggested changes Dec 16, 2017
View reviewed changes
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes.

oltpbench.iml Outdated
@@ -0,0 +1,70 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expunge this file from your commit history and rebase.

pom.xml
@@ -150,5 +150,36 @@
<artifactId>ojdbc14</artifactId>
<version>10.2.0.1.0</version>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedcode @dvanaken I don't think we want to include all these things, right?

src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java Outdated
@@ -645,7 +645,7 @@ protected int loadOrders(Connection conn, int w_id, int districtsPerWarehouse, i
if (order_line.ol_delivery_d != null) {
orlnPrepStmt.setTimestamp(idx++, order_line.ol_delivery_d);
} else {
orlnPrepStmt.setNull(idx++, 0);
orlnPrepStmt.setTimestamp(idx++, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your formatting. This also looks to be a SpliceMachine specific change. Why doesn't "0" work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of forget the complaining message. I just keep receiving the complaining message if I do not change it.

@apavlo apavlo mentioned this pull request Dec 16, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apavlo apavlo apavlo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Covariants @apavlo