Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NubitDA integration #236

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

NubitDA integration #236

wants to merge 12 commits into from

Conversation

sieniven
Copy link
Collaborator

@sieniven sieniven commented Jul 24, 2024

Summary

Nubit backend implementation fixes

  • Add encoding scheme for encoding L2 batches data into NubitDA blobs that will subsequently be sent to NubitDA layer
  • Add encoding scheme for encoding NubitDA blob data into dataAvailabilityMessage
  • Use geth abi library for encoding NubitDA blobs for on-chain decoding using default ABI encoding
  • Resolve issue on GetSequence pipeline - the old backend implementation does not handle the decoding of data availability message correctly (as it was changed to sequence signature)
  • Using the encoding scheme for NubitDA blob data, getSequence pipeline is fixed and blobs are able to be retrieved using their metadata from the Nubit network, using the on-chain data availability message in batch txs

Refactor changes

  • Revert back to the original PostSequence interface - theres no need to change the interface since sequences are signed by the sequence sender private key. Also, we should maintain interfaces for backwards compatibility
  • Add configurable callbacks for blob confirmation on NubitDA layer in post sequence pipeline
  • Minor fixes - code cleanups, better error handling

@sieniven sieniven changed the title Add nubit DA backend NubitDA integration Jul 24, 2024
@sieniven
Copy link
Collaborator Author

cc/ @archidoge0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants