Refactor and use go only #60
Conversation
action.yml
Outdated
| - --timeout=${{ inputs.timeout }} | ||
| - --scope=${{ inputs.scope }} | ||
| - --variables=${{ inputs.variables }} | ||
| - --file=${{ inputs.file }} | ||
| - --branch=${{ inputs.branch }} | ||
| - --log-level=${{ inputs.log-level }} |
There was a problem hiding this comment.
This does need some testing. I haven't checked what the implications are if the inputs are not set. I imagine an empty value will be sent through, which means the final result will not be the default set in the go code.
go.mod
Outdated
|
|
||
| require golang.org/x/text v0.16.0 | ||
|
|
||
| require github.com/hoshsadiq/godotenv v1.0.0 // indirect |
There was a problem hiding this comment.
I used my custom fork of https://github.com/joho/godotenv/ which parses things a lot better. But happy to switch it back to https://github.com/joho/godotenv/, or another one if you have a preference.
| if [ ! -z "$OKTETO_CA_CERT" ]; then | ||
| echo "Custom certificate is provided" | ||
| echo "$OKTETO_CA_CERT" > /usr/local/share/ca-certificates/okteto_ca_cert.crt | ||
| update-ca-certificates | ||
| fi |
There was a problem hiding this comment.
I'm unsure where this is used, so haven't made the relevant changes yet.
There was a problem hiding this comment.
This is to support the scenario where Okteto is using a private CA or a self-signed certificate
| "PreviewURLSuffix": previewURLSuffix, | ||
| "PreviewSuccess": previewSucceeded, | ||
| "Endpoints": endpoints, | ||
| "EndpointsMap": getEndpointsMap(previewURLSuffix, endpoints), |
There was a problem hiding this comment.
This is useful in cases like this:
### :rocket: [Open MyApp]({{ index .EndpointsMap "app" }}) :rocket:
Supporting services are available at the following links:
- [Minio]({{ index .EndpointsMap "minio" }}) - the minio s3 emulator.
- [Database UI]({{ index .EndpointsMap "adminer" }}) - Database editor.Which would translate to something like this:
🚀 Open MyApp 🚀
Supporting services are available at the following links:
- Minio - the minio s3 emulator.
- Database UI - Database editor.
This PR refactors the whole repo and uses go only (where previously it was using bash, go, and ruby). This also adds an extra option to customise the comment that the bot leaves on a PR, which was the main reason I started making changes to the repo.
I've also set it up in a way where it should be easy to add support for additional CI environments.