Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry poc #3294

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

sentry poc #3294

wants to merge 29 commits into from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Jun 30, 2023

@@ -19,7 +19,7 @@ export default BaseFooter.extend({
SignUpLinkWithText = View.extend({
className: 'signup-info',
template: hbs`
<span>{{i18n code="registration.signup.label" bundle="login"}}</span><span class="signup-link"></span>
<span>{{i18n code="registration.signup.label000" bundle="login"}}</span><span class="signup-link"></span>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to trigger translation error


// First run fetchInitialData, in case the next controller needs data
// before it's initial render. This will leave the current page in a
// loading state.
return this.controller
.fetchInitialData()
return createControllerAndFetchInitialData()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap controller initialisation in async function to catch errors in .catch()

@@ -267,6 +272,9 @@ export default Router.extend({
oldController.remove();
oldController.$el.remove();
}

// to catch errors like https://github.com/okta/okta-signin-widget/pull/3276
this.settings.callGlobalError(e);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to catch errors like #3276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant