fix - revert Can't handle redirect

okta · Feb 23, 2024 · 7ec4bcc · 7ec4bcc
1 parent 4093629
commit 7ec4bcc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/samples/routing/react-router-dom-v6-data/src/components/Nav.tsx b/samples/routing/react-router-dom-v6-data/src/components/Nav.tsx
@@ -23,7 +23,7 @@ const Nav = () => {
       <Link id='protected-nav-link' to='/protected'>Protected</Link>
       {isAuthenticated &&
         <>
-          <Link id='protected-nav-link' to='/protected/profile'>Profile</Link>
+          <Link id='protected-profile-nav-link' to='/protected/profile'>Profile</Link>
         </>
       }
     </nav>

diff --git a/src/containers/LoginCallback.tsx b/src/containers/LoginCallback.tsx
@@ -11,7 +11,6 @@
  */
 
 import * as React from 'react';
-import { AuthSdkError } from '@okta/okta-auth-js';
 import useLoginCallback, { LoginCallbackOptions } from '../hooks/useLoginCallback';
 import useComponents, { ComponentsOptions } from '../hooks/useComponents';
 import useOktaAuth from '../context/useOktaAuth';
@@ -27,13 +26,12 @@ const LoginCallback: React.FC<LoginCallbackProps> = ({
   const { ErrorReporter, Loading } = useComponents(oktaContext, options);
 
   if (!isLoginRedirect) {
+    // This can happen if <LoginCallback> is mounted to a wrong route
+    //  or there are no requried query/hash parameters in the URL
     if (children) {
       return (<>{children}</>);
     } else {
-      // This can happen if <LoginCallback> is mounted to a wrong route
-      //  or there are no requried query/hash parameters in the URL
-      const error = new AuthSdkError('Can\'t handle login redirect');
-      return <ErrorReporter error={error} />;
+      return null;
     }
   } else if (callbackError) {
     return <ErrorReporter error={callbackError} />;

diff --git a/test/jest/specs/loginCallback.test.tsx b/test/jest/specs/loginCallback.test.tsx
@@ -172,14 +172,14 @@ describe('<LoginCallback />', () => {
       isLoginRedirect = false;
     });
 
-    it('if there are no children, renders error', async () => {
+    it('if there are no children, renders null', async () => {
       const wrapper = mount(
         <Security {...mockProps}>
           <LoginCallback />
         </Security>
       );
       expect(wrapper.find(LoginCallback).length).toBe(1);
-      expect(wrapper.text()).toBe('AuthSdkError: Can\'t handle login redirect');
+      expect(wrapper.text()).toBe('');
     });
 
     it('renders children as a fallback', async () => {