chore: try out various perf. variants

Signed-off-by: Okiki <[email protected]>
okikio · Mar 3, 2024 · 46c3816 · 46c3816
1 parent 771420b
commit 46c3816
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 14 deletions.
diff --git a/mod.ts b/mod.ts
@@ -88,6 +88,8 @@ export async function* asCodePointsIterator<T extends Uint8Array>(
     const len = str.length;
     while (i < len) {
       const codePoint = str.codePointAt(i)!;
+      if (codePoint === undefined) break; // If codePointAt returns undefined, break the loop.
+
       yield codePoint;
       i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
     }

diff --git a/tests/_arrays.ts b/tests/_arrays.ts
@@ -26,12 +26,13 @@ export async function textDecoderArray<T extends Uint8Array>(
     const str = utf8Decoder.decode(chunk, { stream: true });
 
     // Extract code points in larger batches
-    let i = 0;
-    const size = str.length;
-    while (i < size) {
+    const len = str.length;
+    for (let i = 0; i < len;) {
       const codePoint = str.codePointAt(i)!;
-      arr.push(codePoint);
-      i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      if (codePoint !== undefined) {
+        arr.push(codePoint);
+        i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      }
     }
   }
 

diff --git a/tests/_callbacks.ts b/tests/_callbacks.ts
@@ -50,12 +50,13 @@ export async function textDecoderCallback<T extends Uint8Array>(
     const str = utf8Decoder.decode(chunk, { stream: true });
 
     // Extract code points in larger batches
-    let i = 0;
     const len = str.length;
-    while (i < len) {
+    for (let i = 0; i < len;) {
       const codePoint = str.codePointAt(i)!;
-      cb(codePoint);
-      i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      if (codePoint !== undefined) {
+        cb(codePoint);
+        i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      }
     }
   }
 

diff --git a/tests/_iterators.ts b/tests/_iterators.ts
@@ -25,11 +25,13 @@ export async function* textDecoderIterator<T extends Uint8Array>(
     const str = utf8Decoder.decode(chunk, { stream: true });
 
     // Extract code points in larger batches
-    let i = 0;
-    while (i < str.length) {
+    const len = str.length;
+    for (let i = 0; i < len;) {
       const codePoint = str.codePointAt(i)!;
-      yield codePoint;
-      i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      if (codePoint !== undefined) {
+        yield codePoint;
+        i += codePoint > 0xFFFF ? 2 : 1; // Adjust index based on code point size
+      }
     }
   }
 

diff --git a/tests/mod_bench.ts b/tests/mod_bench.ts
@@ -1,4 +1,11 @@
-import { asCodePointsIterator, asCodePointsCallback } from "../mod.ts";
+import { asCodePointsArray, asCodePointsIterator, asCodePointsCallback } from "../mod.ts";
+
+Deno.bench("asCodePoints Array - benchmark", async () => {
+  const iterable = (async function* () {
+    yield new Uint8Array([0x61, 0xC3, 0xA9, 0xE0, 0xA4, 0xB9, 0xF0, 0x9F, 0x98, 0x82]);
+  })();
+  const result: number[] = await asCodePointsArray(iterable);
+});
 
 Deno.bench("asCodePoints Iterator - benchmark", async () => {
   const iterable = (async function* () {