Speed up Lab conversion with Srgb/LinSrgb fast path, use palette FromStr impl
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Srgb/LinSrgb conversion between u8 and f32/f64 has been special-cased to use a lookup table and approximation. This PR uses that implementation where possible. Speedup gains increase as image size increases. On a 4500x3000 image, a 44% speedup was seen reducing the time from 7.8s to 4.3s after switching from `into_format` to using `into_linear`. The speedup is closer to 15-17% on smaller images (320x200) but still noticeable when measured. Swap to using palette's FromStr implementation for colors. Now 3 or 6 digit hex colors are permitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromStrimplementation for colors. Now 3 or 6 digit hex colors are permitted.Srgb/LinSrgbconversion betweenu8andf32/f64where possible, that version uses a lookup table and approximationSpeedup gains increase as image size increases. On a 4500x3000 image, a 44% speedup was seen reducing the total time to calculate centroids from 7.8s to 4.3s after switching from
into_formatto usinginto_linear. The speedup is closer to 15-17% on smaller images (320x200) but still noticeable when measured.Example speedups for reading in images in
Rgb, converting them toLab, and calculating the centroids. Prompted from this discussion Ogeon/palette#341 (reply in thread)into_formatinto_linear