17.0 estate azey #125

elhayyany · 2024-08-20T13:46:01Z

No description provided.

aboo-odoo · 2024-08-20T14:31:13Z

Ping

aboo-odoo

Good job so far, I've been extra picky so don't take things personally 🏅

Rename your commit PR title to something like [ADD] estate: blablabla and also add a description
Add the string parameter to the fields so that it can get translated, it also make it a bit more understandable
I know this is a training but beware of spelling.

estate/__manifest__.py

estate/models/estate_property.py

estate/models/estate_property_type.py

estate/security/ir.model.access.csv

estate/views/estate_menus.xml

aboo-odoo

Mind the ID naming convention, the guidelines are here

estate/views/estate_property_tag_views.xml

estate/views/estate_property_views.xml

estate/views/estate_menus.xml

estate/views/estate_type_menu.xml

[ADD] estate: adding first action [ADD] estate: ading mnus [ADD] estate: This is my first commit using guidlines In this one there my code for chapters from 1 to 6. [IMP] estate: Imroving style [IMP] estate: improving style'

…perty

aboo-odoo

Very good job! a few last things:

Could you rename the PR title and add a description to your PR
Squash all your commits into one

aboo-odoo · 2024-08-30T07:52:56Z

estate/models/estate_property.py

+        for record in self:
+            record.total_area = record.living_area + record.garden_area


I know they use record in the tutorial, but something more meaningful, like estate will make your code much more readable in the long run

aboo-odoo · 2024-08-30T07:53:25Z

estate/models/estate_property.py

+        for record in self:
+            record.best_price = max(record.offer_ids.mapped('price'), default=0)


same here

Suggested change

for record in self:

record.best_price = max(record.offer_ids.mapped('price'), default=0)

for estate in self:

estate.best_price = max(estate.offer_ids.mapped('price'), default=0)

Btw, I didn't know max took a default value :o Thanks for showing me :D

aboo-odoo · 2024-08-30T07:56:13Z

estate/models/estate_property.py

+
+    def action_sold_property(self):
+        if "canceled" in self.mapped("state"):
+            raise UserError("Canceled properties cannot be sold.")


Like for the string parameter in the fields, we try to make all strings translatable. Usually, it is done automatically, like for the fields name. In exceptions, it is not done automatically yet. To set a manual string as translatable, you have to import _ -> from odoo import _ and use it as such

Suggested change

raise UserError("Canceled properties cannot be sold.")

raise UserError(_("Canceled properties cannot be sold."))

p.s: could you do it for all the other error messages as well

aboo-odoo · 2024-08-30T07:57:59Z

estate/models/estate_property.py

+            self.garden_orientation = False
+
+    def action_sold_property(self):
+        if "canceled" in self.mapped("state"):


This method may be called on several records (self is multiple records). There are two ways to deal with this:
1 - either like you've done in the compute methods with a for estate in self: loop.
2 - or, by adding self.ensure_one() at the beginning of your method. This triggers an error if there are more or less than one record.

Usually, we tend to prefer the 1st option when possible to improve performances of the server.

aboo-odoo · 2024-08-30T07:58:14Z

estate/models/estate_property.py

+            raise UserError("Canceled properties cannot be sold.")
+        return self.write({"state": "sold", "active": False})
+
+    def action_cancel_property(self):


Some for this method about the several records

aboo-odoo · 2024-08-30T08:01:48Z

estate/models/estate_property_offer.py

+            }
+        )
+
+    def action_refused(self):


Same comment about multiple records

aboo-odoo · 2024-08-30T08:01:59Z

estate/models/estate_property_offer.py

+
+    @api.constrains("price", "property_id.expected_price")
+    def check_price(self):
+        for record in self:


Suggested change

for record in self:

for estate in self:

aboo-odoo · 2024-08-30T08:02:39Z

estate/models/estate_property_offer.py

+            date = offer.create_date.date() if offer.create_date else fields.Date.today()
+            offer.validity = (offer.date_deadline - date).days
+
+    def action_accepted(self):


Also, shouldn't this method refuse all other offers if one has been accepted ?

aboo-odoo · 2024-08-30T08:03:14Z

estate/models/estate_property_tag.py

+
+class estatePropertyTag(models.Model):
+    _name = "estate.property.tag"
+    _description = "This module introduces property tags to the real estate model, allowing properties to be categorized with multiple descriptive tags like 'cozy' or 'renovated' using a many-to-many relationship."


Suggested change

_description = "This module introduces property tags to the real estate model, allowing properties to be categorized with multiple descriptive tags like 'cozy' or 'renovated' using a many-to-many relationship."

_description = """

This module introduces property tags to the real estate model, allowing

properties to be categorized with multiple descriptive tags like 'cozy'

or 'renovated' using a many-to-many relationship.

"""

aboo-odoo · 2024-08-30T08:03:58Z

estate/models/estate_property_type.py

+
+    @api.depends("offer_ids")
+    def _compute_offers(self):
+        for record in self:


Suggested change

for record in self:

for property_type in self:

elhayyany force-pushed the 17.0-estate-azey branch 3 times, most recently from 705769b to 0804a8b Compare August 23, 2024 13:12

aboo-odoo reviewed Aug 23, 2024

View reviewed changes

elhayyany force-pushed the 17.0-estate-azey branch from b6ad338 to 62fe36d Compare August 29, 2024 20:56

elhayyany added 22 commits August 29, 2024 23:04

[ADD] estate: creation of estate dir

ace946e

[ADD] estate: creation of estate mainfest

239f6e9

[ADD] estate: mv mainfes to manifest

db2623a

[ADD] estate: converting estate to app

a072d75

[ADD] estate: createing the tabe and it fields

a4dfa7e

[ADD] estate: adding first action [ADD] estate: ading mnus [ADD] estate: This is my first commit using guidlines In this one there my code for chapters from 1 to 6. [IMP] estate: Imroving style [IMP] estate: improving style'

[IMP] estate: fixing all style errors in estate directory

4fc79af

[IMP] estate: fixing all style errors in TUTORIALS directory

36ea210

[IMP] estate: fixing all style errors in TUTORIALS directory

52fb196

[IMP] estate: fixing all style errors in TUTORIALS directory

3737b95

[ADD] estate: I added access rights to estate_property_type model

316cb51

[ADD] estate: I added license to estate manifest

b5f7bc5

[ADD] estate: I Buyer and salesman atributes to estate_property model

ad34fad

[ADD] estate: I added the Property tag view and link it to estate pro…

fc9ce5e

…perty

[ADD] estate: saving ..

6948985

[IMP] estate: Made revisions based on reviewer feedback

e41e358

[IMP] estate: Made revisions based on reviewer feedback

b2b7d20

[IMP] estate: Made revisions based on reviewer feedback

c2a1bcd

[ADD] estate: I add What was asked in chapters 'till 11

d2f29a1

[ADD] estate: I add chapter up to 11

0b83187

[IMP] estate: style improving to match runbot requirements

f1eb78b

[IMP] estate: style improving to match runbot requirements

7cc8aef

[IMP] estate: style improving to match runbot requirements

75606fb

elhayyany force-pushed the 17.0-estate-azey branch from 62fe36d to 75606fb Compare August 29, 2024 21:07

[IMP] estate: style improving to match runbot requirements

e79faca

aboo-odoo reviewed Aug 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

17.0 estate azey #125

17.0 estate azey #125

elhayyany commented Aug 20, 2024

aboo-odoo commented Aug 20, 2024

aboo-odoo left a comment •

edited

Loading

aboo-odoo left a comment

aboo-odoo left a comment

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

aboo-odoo Aug 30, 2024

		for record in self:
		record.total_area = record.living_area + record.garden_area

		for record in self:
		record.best_price = max(record.offer_ids.mapped('price'), default=0)

	raise UserError("Canceled properties cannot be sold.")
	raise UserError(_("Canceled properties cannot be sold."))

17.0 estate azey #125

Are you sure you want to change the base?

17.0 estate azey #125

Conversation

elhayyany commented Aug 20, 2024

aboo-odoo commented Aug 20, 2024

aboo-odoo left a comment • edited Loading

Choose a reason for hiding this comment

aboo-odoo left a comment

Choose a reason for hiding this comment

aboo-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aboo-odoo left a comment •

edited

Loading