[ADD] estate: Created Real Estate Application #111

akpu-odoo · 2024-08-02T12:28:13Z

Real Estate Module for training

Enhanced estate_property model by adding new fields and applying constraints as outlined in the chapters. Configured required fields, default values, and non-copyable settings to ensure data integrity and proper functionality. Added some views specified in the chapters.

Enhanced estate_property model by adding new fields and applying constraints as outlined in the chapters. Configured required fields, default values, and non-copyable settings to ensure data integrity and proper functionality. Added some views specified in the chapters

- Added relational fields: - `EstateProperty` has a One2many relationship with `EstatePropertyOffer`. - `EstatePropertyOffer` has a Many2one relationship with `EstateProperty`. - Implemented a Many2many relationship between `EstateProperty` - Added computed fields `deadline_date` and `validity` with proper compute and inverse methods. `deadline_date` and `created_date`. - Added `onchange` method to dynamically update fields based on user input. - Added action button in the view - Resets the property's buyer and selling price if the offer is rejected by the buyer. - Raises `UserError` if the offer cannot be rejected. - Ensured that the `EstateProperty` model has the `buyer_id` and `selling_price` fields.

adsh-odoo

Hello @akpu-odoo

Added few remarks primarily related to guidelines for cleaning up the code.
Beside this the checkstyle of runbot is also failing due to linting issue Can you please resolve that also.

Thanks

adsh-odoo · 2024-08-12T05:55:50Z

estate/__manifest__.py

+    'license': 'LGPL-3',
+
+    'summary': "Starting module for Real Estate Business model",
+


No need for the blank lines here.

adsh-odoo · 2024-08-12T06:09:13Z

estate/models/estate_property_tag.py

@@ -0,0 +1,15 @@
+from odoo import fields, models
+


Generally, between imports and declaration of class, we give two blank lines.

adsh-odoo · 2024-08-12T06:10:08Z

estate/models/estate_property_tag.py

+        ('unique_property_tag','unique(name)','The property tag should be unique')
+    ]
+
+


No need for these blank lines here Also we give only one blank line when we start declaring fields after defining the model attributes.

adsh-odoo · 2024-08-12T06:15:23Z

estate/models/estate_property_offer.py

+            else:
+                raise UserError("You cannot reject this offer")
+    # def action_refuse(self):
+    #         if self.property_id.buyer == self.property_id:


Avoid pushing the commented code if you require some code for future purposes probably you could stash them or make a patch file to use them.

adsh-odoo · 2024-08-12T06:25:51Z

estate/views/list_model_view.xml

+    </record>
+
+
+</odoo>


Make sure to add the blank lines at the end of the file.

adsh-odoo · 2024-08-12T08:50:08Z

estate/models/estate_property.py

@@ -0,0 +1,107 @@
+from odoo import fields, models ,api
+from datetime import datetime, timedelta


External libraries are imported first before the import of odoo.

adsh-odoo · 2024-08-12T09:00:30Z

estate/models/estate_property_offer.py

+    property_id = fields.Many2one('estate.property', required=True)
+    validity = fields.Integer(default=7)
+    deadline_date = fields.Date(compute="_compute_validity", inverse="_inverse_validity",store=True)
+    created_date = fields.Date(default=lambda self: datetime.today())


Suggested change

created_date = fields.Date(default=lambda self: datetime.today())

create_date = fields.Date(default=lambda self: datetime.today())

I think we can override the existing create_date field here instead a new field.

adsh-odoo · 2024-08-12T09:02:06Z

estate/models/estate_property_offer.py

+    @api.depends("validity", "created_date")
+    def _compute_validity(self):
+        for record in self:
+            if record.created_date:


As we are providing the default value in the field so I think there is no need for this extra check

adsh-odoo · 2024-08-12T09:15:29Z

estate/models/estate_property_offer.py

+            else:
+                record.deadline_date = False
+
+    @api.depends("created_date", "deadline_date")


No need for this i think we can keep the generic behavior of inverse method that reflects the changes after saving the records in our usecase.

adsh-odoo · 2024-08-12T09:35:58Z

estate/models/estate_property.py

+                record.best_offer = 0
+
+    @api.onchange("garden")
+    def _onchange_(self):


Give the method name as per the use cases and try avoiding the generic keywords.

- Added relational fields - Added Tree View for Property Offers - Connected Property Types and Property Offers with Relational Models

-Added master data for standard Real Estate Property Types: Residential, Commercial, Industrial, and Land. -Added demo data for the estate module, including properties like Big Villa and Trailer Home. -Created demo data for offers linked to demo properties using existing partners. -Ensured that demo properties have their Property Type set to Residential. -Added date handling for demo offers to be relative to the module installation date. -Utilized Command methods to create offers directly within the One2many field of a new property. -Implemented data extension examples for XML-based record updates. Completed chapter till Demo Data. Created estate_property_templates.xml to define the report template for displaying property offers. Added estate_property_reports.xml for the ir.actions.report to include the report in the module's business logic. Enhanced the report by adding logic to conditionally handle cases with no offers using t-if and t-else. -Extended the property report in the estate_account module to include invoice information for sold properties using QWeb inheritance.y Types and Property Offers with Relational Models

-Web Controllers: Implemented new web controllers to handle property-related HTTP requests, enhancing the web functionality of the estate module. -Wizard Implementation: Introduced a wizard to streamline the process of creating and assigning offers to multiple properties simultaneously.

-Web Controllers: Implemented new web controllers to handle property-related HTTP requests, enhancing the web functionality of the estate module. -Wizard Implementation: Introduced a wizard to streamline the process of creating and assigning offers to multiple properties simultaneously. -Fixed some linting issues

-Created Agent and Manger -Implemented the Access Right to Agent and Manager

- Added new module make meeting - created a new meeting function to add event to calendar

- Created Models in the module as per given instructions - Created some Actions and views in the module

- Added Invoicing and reports to in the module - Added sequencing in the tree view of all models - Added some models as per given instructions

- Added controller in the module as per given task - patient details page - Designed the overall ui of module

akpu-odoo added 4 commits August 1, 2024 12:44

adsh-odoo reviewed Aug 12, 2024

View reviewed changes

akpu-odoo added 5 commits August 12, 2024 15:15

[IMP] estate: Improved Real Estate Application

d54efef

- Added relational fields - Added Tree View for Property Offers - Connected Property Types and Property Offers with Relational Models

[IMP] estate: solved some linting issues

6b21de4

[ADD] estate: fixed some linting problems

34908ba

akpu-odoo force-pushed the 17.0-training-akpu branch from 62ec201 to 53c9f50 Compare August 27, 2024 11:28

akpu-odoo added 8 commits August 27, 2024 17:07

[IMP] estate: Implemented Access Right to Agent and Manager

4fa0645

-Created Agent and Manger -Implemented the Access Right to Agent and Manager

[IMP] estate: Implemented Access Right to Agent and Manager

01a2674

-Created Agent and Manger -Implemented the Access Right to Agent and Manager

[IMP] estate: Added new wizard task

f485dc5

- Added new module make meeting - created a new meeting function to add event to calendar

[IMP] estate: Added new wizard task

3b6508c

- Added new module make meeting - created a new meeting function to add event to calendar

[ADD] dental: Created a new module Dental

39726f5

- Created Models in the module as per given instructions - Created some Actions and views in the module

[IMP] dental: Added Functionalities to the module

e802298

- Added Invoicing and reports to in the module - Added sequencing in the tree view of all models - Added some models as per given instructions

akpu-odoo force-pushed the 17.0-training-akpu branch from d7b5642 to fc124a9 Compare September 6, 2024 13:02

[IMP] dental: Added additional feature

bf03017

- Added controller in the module as per given task - patient details page - Designed the overall ui of module

akpu-odoo force-pushed the 17.0-training-akpu branch from fc124a9 to bf03017 Compare September 10, 2024 12:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] estate: Created Real Estate Application #111

[ADD] estate: Created Real Estate Application #111

akpu-odoo commented Aug 2, 2024

adsh-odoo left a comment

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024

adsh-odoo Aug 12, 2024 •

edited

Loading

		'license': 'LGPL-3',

		'summary': "Starting module for Real Estate Business model",

		('unique_property_tag','unique(name)','The property tag should be unique')
		]

		@@ -0,0 +1,107 @@
		from odoo import fields, models ,api
		from datetime import datetime, timedelta

	created_date = fields.Date(default=lambda self: datetime.today())
	create_date = fields.Date(default=lambda self: datetime.today())

		</record>


		</odoo>

[ADD] estate: Created Real Estate Application #111

Are you sure you want to change the base?

[ADD] estate: Created Real Estate Application #111

Conversation

akpu-odoo commented Aug 2, 2024

adsh-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adsh-odoo Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

adsh-odoo Aug 12, 2024 •

edited

Loading