[ADD] estate: Added new real estate property management module #110

akya-odoo · 2024-08-02T12:28:04Z

Added real estate module for training

The new module includes: - Model: estate.property with fields such as name, description, selling_price, availability_date, bedrooms, state, and active. - Views: Tree and form views for managing estate properties. - Security: Access rights defined in ir.model.access.csv.

Enhanced estate module by updating estate_property model and views, adding new m odels for estate_property_offer, estate_property_tag, and estate_property_type, and refining access control and menus. Improved estate_property_views functional ity for better user experience.

Update UI elements for improved user experience. - Added SQL and python constraints. - Enhanced User interface of the module.

adsh-odoo

Hello @akya-odoo

I have added some remarks to cleanup the code.
Can you please have a look?

Thanks!!

adsh-odoo · 2024-08-13T05:28:17Z

estate/models/__init__.py

@@ -0,0 +1 @@
+from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer, res_users


Suggested change

from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer, res_users

from . import estate_property

from . import estate_property_offer

from . import estate_property_tag

from . import estate_property_type

from . import res_users

Generally, we import every model in new lines.

adsh-odoo · 2024-08-13T05:30:21Z

estate/views/estate_property_type_view.xml

+
+
+
+


Suggested change

adsh-odoo · 2024-08-13T05:42:45Z

estate/models/estate_property_offer.py

+from odoo import models, fields, api
+from datetime import timedelta


Suggested change

from odoo import models, fields, api

from datetime import timedelta

from datetime import timedelta

from odoo import api, fields, model

Generally we follow a convention in which we first we import all the external libraries and then the import of odoos in alphabetical order.

adsh-odoo · 2024-08-13T06:15:18Z

estate/views/estate_property_offer_view.xml

+    </record>
+
+
+</odoo>


Need a blank line at EOF

adsh-odoo · 2024-08-13T06:15:55Z

estate/views/estate_property_views.xml

+                </p>
+            </field>
+    </record>
+


Suggested change

Same for below also

adsh-odoo · 2024-08-13T06:39:51Z

estate/models/estate_property.py

+    _sql_constraints = [
+        ('check_expected_price', 'CHECK(expected_price > 0)', 'The expected price must be strictly positive.'),
+        ('check_selling_price', 'CHECK(selling_price >= 0)', 'The selling price must be positive.')
+    ]


Generally we define constraints just after field defination.

adsh-odoo · 2024-08-13T06:43:05Z

estate/models/estate_property_offer.py

+        self.status = 'refused'
+        return True
+
+    _sql_constraints = [


same here for constraints

adsh-odoo · 2024-08-13T07:26:09Z

estate/views/estate_property_type_view.xml

+                <button type="action" name="estate.action_estate_property_offer" string="Offers" class="oe_stat_button" icon="fa-archive" style= "align: right;">
+                </button>


Suggested change

<button type="action" name="estate.action_estate_property_offer" string="Offers" class="oe_stat_button" icon="fa-archive" style= "align: right;">

</button>

<div name="button_box">

<button class="oe_stat_button" type="action" name="%(estate.action_estate_property_offer)d"

icon="fa-pencil-square-o">

<field string="Offers" name="offer_count" widget="statinfo"/>

</button>

</div>

I think we can do something like this inside sheet instead of header to properly format the stat button.

adsh-odoo · 2024-08-13T07:26:47Z

estate/views/estate_property_type_view.xml

+                <sheet>
+                     <div>
+                        <h1><field name="name"/></h1>
+                        <field name="offer_count" readonly="1"/>


No need for this after applying the previous comment.

adsh-odoo · 2024-08-13T09:15:05Z

estate/models/estate_property.py

+            self.state = "canceled"
+        elif self.state == "sold":
+            raise UserError("This property can't be canceled as it is sold already")
+        return True


Suggested change

return True

I think it is not necessary check for all the actions.

adsh-odoo · 2024-08-13T11:41:03Z

estate/models/estate_property_offer.py

+        for record in self:
+            if record.create_date:
+                record.date_deadline = record.create_date + timedelta(days=record.validity)
+            else:
+                record.date_deadline = fields.Date.today() + timedelta(days=record.validity)


Suggested change

for record in self:

if record.create_date:

record.date_deadline = record.create_date + timedelta(days=record.validity)

else:

record.date_deadline = fields.Date.today() + timedelta(days=record.validity)

record.deadline_date = record.property_id.create_date + relativedelta(

days=record.validity

)

adsh-odoo · 2024-08-13T11:42:09Z

estate/models/estate_property_offer.py

+            if record.date_deadline and record.create_date:
+                create_date_date = record.create_date.date()
+                record.validity = (record.date_deadline - create_date_date).days
+            else:
+                record.validity = 0


Suggested change

if record.date_deadline and record.create_date:

create_date_date = record.create_date.date()

record.validity = (record.date_deadline - create_date_date).days

else:

record.validity = 0

record.validity = (record.deadline_date - record.property_id.create_date.date()).days

Can you give it a try? Make sure to check all possible cases.
same for compute also

- Updated data files to reflect recent changes in property and offer models. - Enhanced security for estate-related models. - Added security rules to ensure proper access levels for different user roles.

- Implemented patient form with linked guarantor information (phone, email, etc) - Added functionality to handle invoicing for dental treatments - Updated UI elements for better user experience and accessibility

Implemented patient details page for Dental module. Added controller route to di splay patient-specific information with sections for Personal, Medical History, Medical Aid, and Dental History. Integrated responsive design with Bootstrap car ds and breadcrumbs navigation.

Created a module for managing installments, including a cron job for invoices. Added a settings section specifically for installments. Implemented a wizard for adding EMI (Equated Monthly Installments). Introduced a button to redirect to the document module. Implemented an invoice schedule that triggers when the delay process exceeds the specified days. Added a smart button for document upload requests. Developed a wizard for document requests related to sales orders.

akya-odoo added 6 commits August 1, 2024 12:55

[ADD] estate: Add new real estate property management module

629dbab

akya-odoo force-pushed the 17.0-training-akya branch 4 times, most recently from 6aa9cca to 28a53ce Compare August 7, 2024 12:42

akya-odoo force-pushed the 17.0-training-akya branch from 28a53ce to 0ec7bd9 Compare August 7, 2024 12:58

[ADD] estate: added new UI elements and constraints

45e4a94

Update UI elements for improved user experience. - Added SQL and python constraints. - Enhanced User interface of the module.

akya-odoo force-pushed the 17.0-training-akya branch from 19a0abb to 45e4a94 Compare August 12, 2024 10:08

adsh-odoo reviewed Aug 13, 2024

View reviewed changes

[IMP] estate: implemented modifications in data and security

e6f6928

- Updated data files to reflect recent changes in property and offer models. - Enhanced security for estate-related models. - Added security rules to ensure proper access levels for different user roles.

akya-odoo force-pushed the 17.0-training-akya branch from ff21063 to e6f6928 Compare September 3, 2024 06:55

akya-odoo added 2 commits September 5, 2024 18:53

[IMP] dental: added the functionalities

b81da5f

- Implemented patient form with linked guarantor information (phone, email, etc) - Added functionality to handle invoicing for dental treatments - Updated UI elements for better user experience and accessibility

akya-odoo force-pushed the 17.0-training-akya branch from bcf2156 to c1279d3 Compare September 20, 2024 10:28

akya-odoo force-pushed the 17.0-training-akya branch from c1279d3 to 6beee95 Compare September 20, 2024 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] estate: Added new real estate property management module #110

[ADD] estate: Added new real estate property management module #110

akya-odoo commented Aug 2, 2024

adsh-odoo left a comment

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

adsh-odoo Aug 13, 2024

		@@ -0,0 +1 @@
		from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer, res_users

-from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer, res_users
+from . import estate_property
+from . import estate_property_offer
+from . import estate_property_tag
+from . import estate_property_type
+from . import res_users

		from odoo import models, fields, api
		from datetime import timedelta

		<button type="action" name="estate.action_estate_property_offer" string="Offers" class="oe_stat_button" icon="fa-archive" style= "align: right;">
		</button>

-                <button type="action" name="estate.action_estate_property_offer" string="Offers" class="oe_stat_button" icon="fa-archive" style= "align: right;">
-                </button>
+                <div name="button_box">
+                        <button class="oe_stat_button" type="action" name="%(estate.action_estate_property_offer)d"
+                            icon="fa-pencil-square-o">
+                            <field string="Offers" name="offer_count" widget="statinfo"/>
+                        </button>
+                    </div>

		</record>


		</odoo>

[ADD] estate: Added new real estate property management module #110

Are you sure you want to change the base?

[ADD] estate: Added new real estate property management module #110

Conversation

akya-odoo commented Aug 2, 2024

adsh-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment