Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the PR is blocked before pinging about awaiting action #930

Open
xmo-odoo opened this issue Aug 16, 2024 · 0 comments
Open

Check if the PR is blocked before pinging about awaiting action #930

xmo-odoo opened this issue Aug 16, 2024 · 0 comments
Labels
mergebot

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Aug 16, 2024 •
edited
Loading

In case the mergebot falls behind on the queue (because it has to merge a thousand broken PRs because everything is urgent for whatever demo is upcoming). it can start PRs which have been validated and approved but it just hasn't merged yet.

That's... putting salt on the wound to put it mildly, as the developers would have appreciated the PR be long merged.

Examples:
@xmo-odoo xmo-odoo mentioned this issue Sep 4, 2024
Open
xmo-odoo added a commit that referenced this issue Sep 6, 2024
@xmo-odoo
[FIX] forwardport: don't post reminder on PRs waiting to be staged
017b8d4 
The FW reminder is useful to remind people of the outstanding forward
ports they need to process, as taking too long can be an issue.

They are, however, not useful if the developer has already done
everything, the PR is ready and unblocked, but the mergebot has fallen
behind and has a hard time catching up. In that case there is nothing
for the developer to do, so pinging them is not productive, it's only
frustrating.

Fixes #930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mergebot
Projects
Mergebot
Status: done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xmo-odoo