Investigate r+/retry getting no feedback and not working #939
Labels
Comments
xmo-odoo
added a commit
that referenced
this issue
Sep 6, 2024
In some cases, feedback to the PR author that an r+ is redundant went missing. This turns out to be due to the convolution of the handling of approval on forward-port, and the fact that the target PR is treated exactly like its ancestors: if the PR is already approved the approval is not even attempted (and so no feedback if it's incorrect). Straighten up this bit and add a special case for the PR being commented on, it should have the usual feedback if in error or already commented on. Furthermore, update `PullRequests._pr_acl` to kinda work out of the box for forward-port: if the current PR is a forward port, `is_reviewer` should check delegation on all ancestors, there doesn't seem to be any reason to split "source_reviewer", "parent_reviewer", and "is_reviewer". Fixes #939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
odoo/enterprise#68183
Staging fails which is fine, but then:
retry has no effect and no feedbackturns out the comment was posted as r+ then edited to retryOther task with same issue: odoo/odoo#178748 first review (2024-09-02T13:48:09) transitioned the PR to ready, but 17.2 is currently very slow so the PR was not merged, user didn't notice the PR was reviewed so tried to review it after being pinged (due to #930), kept doing it as they got no feedback that the review is redundant
The text was updated successfully, but these errors were encountered: