-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on all branches #47
Conversation
What is the purpose? |
Well, the previous one just did not build it on master, only on main, so it was not complete. |
I mean, I'm not sure we really need the container for every push. |
I am not sure I understand, building container for every push was merged in there which you approved? If the package changes, containers which use it should be rebuilt. Or you suggest to have different versions of this package in mmoda and galaxy bot versions? |
Pushing to master is not so often, it's ok. |
As long as it is part of this project, the branch will be merged eventually and will end up installed in mmoda bot container too. So it's important that the container build passes, so it functions as a test. If you are making many small commits and do not want to see failures you can exclude it temporarily. If the galaxy feature is so divergent that it should not be part of the mmoda instance of oda-bot, it can be moved out of this repository. Although I think it's rather related it makes sense that it is part if of. |
OK, building container as a kind of test makes sense. Temporarily excluding branch could be an option. I will then probably propose the other way around, kind of "no-container" label instead of "build-container" label. Will do in galaxy branch. |
No description provided.