Only build co-installable packages on supported compilers #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 . Thanks for the PR, some work needs to be done on ocaml-multicore-ci config before the merge. |
benmandrew
force-pushed
the
co-installable
branch
from
103e15f
to
dc3390e
Compare
|
@moyodiallo the work has been done here: ocurrent/ocaml-multicore-ci#41 Can this PR be merged and deployed? After that I can update |
moyodiallo
approved these changes
Feb 8, 2023
|
Yes, after an extra-review, it can be merged and deployed on the |
moyodiallo
pushed a commit
that referenced
this pull request
Feb 14, 2023
moyodiallo
pushed a commit
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for ocurrent/ocaml-ci#470. The functionality for filtering out incompatible root packages already existed in the code, but it was prevented from working by the explicit multicore-release check.
#38 is a solution for the special case of OCaml 5, but is only necessary in the presence of the multicore check. As far as I can tell the check is no longer necessary now that OCaml 5 is released and domains/effects are packages.
While it seems to work on my end I'd appreciate feedback from someone more knowledgeable.