Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlays repo on Windows #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dra27
Copy link
Collaborator

@dra27 dra27 commented Jan 5, 2022

This is WIP - opening with a trial version to test the fix.

This applies a previous version of the change in ocurrent/docker-base-images#147 to Dockerfile_opam.all_ocaml_compilers and Dockerfile_opam.separate_ocaml_compilers, but these two functions aren't used anywhere anymore.

@dra27
Copy link
Collaborator Author

dra27 commented Jan 5, 2022

@avsm - I think these two functions were for obi and aren't being used/tested anywhere. Up to you whether it's worth putting this in, therefore (I only landed on updating them because the Windows changes had previously been made by @MisterDA!)

@MisterDA
Copy link
Contributor

This is becoming interesting again, also because opam-repository-mingw is starting to be too old. It's odd that this PR wasn't merged sooner. I'm tempted to test this and add the ocaml/opam-repository to Windows images too.

@dra27
Copy link
Collaborator Author

dra27 commented Feb 23, 2023

This didn't need to be merged for the base images - the repo is added there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants