Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odnnr 202 #22842

Closed
wants to merge 2 commits into from
Closed

Odnnr 202 #22842

wants to merge 2 commits into from

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@mseri
Copy link
Member

mseri commented Jan 13, 2023

Only on ocaml 5.0 it fails with

#=== ERROR while compiling odnnr.2.0.2 ========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/UnixJunkie/odnnr/archive/v2.0.2.tar.gz)
# path                 ~/.opam/5.0/.opam-switch/build/odnnr.2.0.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p odnnr -j 31
# exit-code            1
# env-file             ~/.opam/log/odnnr-7-86ec1e.env
# output-file          ~/.opam/log/odnnr-7-86ec1e.out
### output ###
# (cd _build/default && /home/opam/.opam/5.0/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.model.eobjs/byte -I /home/opam/.opam/5.0/lib/batteries -I /home/opam/.opam/5.0/lib/camlp-streams -I /home/opam/.opam/5.0/lib/cpm -I /home/opam/.opam/5.0/lib/dolog -I /home/opam/.opam/5.0/lib/domainslib -I /home/opam/.opam/5.0/lib/lockfree -I /home/opam/.opam/5.0/lib/minicli -I /home/opam/.opam/5.0/lib/num -I /home/opam/.opam/5.0/lib/ocaml/str -I /home/opam/.opam/5.0/lib/ocaml/threads -I /home/opam/.opam/5.0/lib/ocaml/unix -I /home/opam/.opam/5.0/lib/parany -I src/.odnnr.objs/byte -no-alias-deps -o src/.model.eobjs/byte/model.cmo -c -impl src/model.ml)
# File "src/model.ml", line 268, characters 29-37:
# 268 |               Parmap.parmap ~core_pin ncores (fun (train_fn, test_fn) ->
#                                    ^^^^^^^^
# Error: The function applied to this argument has type
#          ?preserve:bool -> ?csize:int -> 'a list
# This argument cannot be applied with label ~core_pin

@UnixJunkie
Copy link
Contributor Author

ok, I need to update the code.

@kit-ty-kate
Copy link
Member

ping @UnixJunkie

@UnixJunkie
Copy link
Contributor Author

Ok, I will have a look at it today.

@UnixJunkie
Copy link
Contributor Author

at least parany-11 is needed

@UnixJunkie
Copy link
Contributor Author

an upper bound might be needed too; I am looking for it

@UnixJunkie
Copy link
Contributor Author

superseded by #23309

@UnixJunkie UnixJunkie closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants